Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Discover] Hide multi fields in Doc Viewer (#101929) #102541

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

majagrubic
Copy link
Contributor

Backports the following commits to 7.x:

* Add multifields flag in the Advanced settings

* Implement hiding of multifields

* Update failing unit test

* Fix telemetry

* Show muti fields in a single doc view

* Mock getServices so that tests pass

* Readd fields to sidebar

* Removing showMultifields flag from angular

* Remove unnecessary import

* Applying text changes according to Gails suggestion

* Fix i18n error

Co-authored-by: Kibana Machine <[email protected]>
@majagrubic majagrubic enabled auto-merge (squash) June 17, 2021 17:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 51 52 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 411.5KB 430.1KB +18.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 74.7KB 76.8KB +2.0KB
Unknown metric groups

API count

id before after diff
discover 64 65 +1

async chunk count

id before after diff
discover 8 7 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit c238029 into elastic:7.x Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants