Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature branch] index pattern => data view for user facing content #109821

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
d5faaf7
[index pattern management] index pattern => data view for user facing…
mattkime Aug 24, 2021
1601ba8
[index pattern field editor] index patterns => data views for user fa…
mattkime Aug 24, 2021
2220a35
[index pattern editor] index pattern to data view for user facing con…
mattkime Aug 24, 2021
e70fc15
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 24, 2021
60d8efc
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 24, 2021
74067f8
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 26, 2021
742b213
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 26, 2021
9dd8a91
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 28, 2021
476ac77
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 30, 2021
82e2199
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Aug 31, 2021
36d0b76
[Maps] 'index patter' -> 'data view' in user facing copy (#110701)
nreese Sep 1, 2021
9288cee
[data plugin] index pattern => data view text changes (#109576)
mattkime Sep 2, 2021
e02085a
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 2, 2021
da762c5
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 2, 2021
fc4db31
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 2, 2021
a16c3f7
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 3, 2021
130689f
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 5, 2021
05ff7ee
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 7, 2021
3bc77b4
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 7, 2021
dcbb5be
[Alerting] Rename index pattern to data view (#111137)
ymao1 Sep 7, 2021
0b22fe1
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 9, 2021
42a4f1f
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 9, 2021
470f14f
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 13, 2021
ec01729
fix i18n
mattkime Sep 13, 2021
a66ceee
[APM] Change terminology: "index pattern" becomes "data view" (#112166)
cauemarcondes Sep 15, 2021
998452a
t push
mattkime Sep 15, 2021
2909101
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 16, 2021
2e38b6c
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 21, 2021
4fd39a3
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 23, 2021
add9c02
[ML] Transforms: Index pattern to data view in user facing copy (#112…
peteharverson Sep 23, 2021
9884ae2
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 23, 2021
437a90a
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 23, 2021
013f591
change name of index pattern management for roles priv (#113053)
mattkime Sep 24, 2021
97cbef7
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 24, 2021
4837783
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 24, 2021
fbc19d6
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 27, 2021
1d4e882
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 27, 2021
be03ad5
[ML] Updates index pattern to data view in user facing copy (#112984)
peteharverson Sep 27, 2021
b21b8a3
change index patterns to data views for deprecation UI (#113209)
mattkime Sep 28, 2021
0ee4a04
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 29, 2021
f1f326b
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 29, 2021
664d64a
add display name to index pattern saved objects (#113350)
mattkime Sep 29, 2021
6ef8079
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 29, 2021
c5d1c33
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 30, 2021
25b790b
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Sep 30, 2021
43b2870
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Sep 30, 2021
73cd567
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 1, 2021
06fd0ae
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 3, 2021
401b384
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 6, 2021
cf7b9dd
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 6, 2021
68bf0d1
fix merge mistake
mattkime Oct 6, 2021
fd54eb1
fix i18n
mattkime Oct 6, 2021
763c360
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 7, 2021
00736dc
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 7, 2021
36df72a
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 7, 2021
bf69e10
[ML] Data Visualizer: index pattern to data view in user facing copy …
peteharverson Oct 7, 2021
d393aeb
[Discover] Rename Index pattern to Data view (#110402)
DianaDerevyankina Oct 8, 2021
f21d74e
[Graph] Rename Index pattern to Data view (#110403)
DianaDerevyankina Oct 8, 2021
ee18af7
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 9, 2021
8f28088
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Oct 9, 2021
f2d4832
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 11, 2021
629647e
[Visualize] Wizard rename Index pattern to Data view (#110251) (#114443)
DianaDerevyankina Oct 11, 2021
2132c7a
[TSVB] Rename Index pattern to Data view (#110253) (#114444)
DianaDerevyankina Oct 11, 2021
d56d313
[Lens] Rename Index pattern to Data view (#110252) (#114445)
DianaDerevyankina Oct 11, 2021
dc18dec
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 11, 2021
835dc8e
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Oct 11, 2021
5e8f329
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 12, 2021
f68a477
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 13, 2021
a424280
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 13, 2021
d67a7f4
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 19, 2021
f5656e9
merge
mattkime Oct 19, 2021
648c042
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 19, 2021
ef366f0
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 19, 2021
0a8cd82
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 19, 2021
31cc6d1
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 20, 2021
4e84b93
trans
mattkime Oct 20, 2021
76f3eee
undo some doc changes
mattkime Oct 20, 2021
b2f38da
update snapshot
mattkime Oct 20, 2021
7787e80
Merge branch 'master' into index_patterns_to_data_views_user_content_…
kibanamachine Oct 20, 2021
3b414e8
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 20, 2021
996ae7b
Merge branch 'index_patterns_to_data_views_user_content_feature_branc…
mattkime Oct 20, 2021
2997f47
Merge branch 'master' into index_patterns_to_data_views_user_content_…
mattkime Oct 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/data/common/search/aggs/param_types/field.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class FieldParamType extends BaseParamType {
'data.search.aggs.paramTypes.field.notFoundSavedFieldParameterErrorMessage',
{
defaultMessage:
'The field "{fieldParameter}" associated with this object no longer exists in the index pattern. Please use another field.',
'The field "{fieldParameter}" associated with this object no longer exists in the data view. Please use another field.',
values: {
fieldParameter: field.name,
},
Expand All @@ -75,7 +75,7 @@ export class FieldParamType extends BaseParamType {
'data.search.aggs.paramTypes.field.invalidSavedFieldParameterErrorMessage',
{
defaultMessage:
'Saved field "{fieldParameter}" of index pattern "{indexPatternTitle}" is invalid for use with the "{aggType}" aggregation. Please select a new field.',
'Saved field "{fieldParameter}" of data view "{indexPatternTitle}" is invalid for use with the "{aggType}" aggregation. Please select a new field.',
values: {
fieldParameter: field.name,
aggType: aggConfig?.type?.title,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const getEsaggsMeta: () => Omit<EsaggsExpressionFunctionDefinition, 'fn'>
types: ['index_pattern'],
required: true,
help: i18n.translate('data.search.functions.esaggs.index.help', {
defaultMessage: 'Index pattern retrieved with indexPatternLoad',
defaultMessage: 'Data view retrieved with indexPatternLoad',
}),
},
aggs: {
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/data/common/search/expressions/esdsl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,12 @@ export const getEsdslFn = ({

request.stats({
indexPattern: {
label: i18n.translate('data.search.es_search.indexPatternLabel', {
defaultMessage: 'Index pattern',
label: i18n.translate('data.search.es_search.dataViewLabel', {
defaultMessage: 'Data view',
}),
value: args.index,
description: i18n.translate('data.search.es_search.indexPatternDescription', {
defaultMessage: 'The index pattern that connected to the Elasticsearch indices.',
defaultMessage: 'The data view that connected to the Elasticsearch indices.',
}),
},
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@ export function getRequestInspectorStats(searchSource: ISearchSource) {

if (index) {
stats.indexPattern = {
label: i18n.translate('data.search.searchSource.indexPatternLabel', {
defaultMessage: 'Index pattern',
label: i18n.translate('data.search.searchSource.dataViewLabel', {
defaultMessage: 'Data view',
}),
value: index.title,
description: i18n.translate('data.search.searchSource.indexPatternDescription', {
defaultMessage: 'The index pattern that connected to the Elasticsearch indices.',
description: i18n.translate('data.search.searchSource.dataViewDescription', {
defaultMessage: 'The data view that was queried.',
}),
};
stats.indexPatternId = {
label: i18n.translate('data.search.searchSource.indexPatternIdLabel', {
defaultMessage: 'Index pattern ID',
label: i18n.translate('data.search.searchSource.dataViewIdLabel', {
defaultMessage: 'Data view ID',
}),
value: index.id!,
description: i18n.translate('data.search.searchSource.indexPatternIdDescription', {
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/data_views/common/data_views/data_views.ts
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export class DataViewsService {

this.onError(err, {
title: i18n.translate('dataViews.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
defaultMessage: 'Error fetching fields for data view {title} (ID: {id})',
values: { id: indexPattern.id, title: indexPattern.title },
}),
});
Expand Down Expand Up @@ -341,7 +341,7 @@ export class DataViewsService {

this.onError(err, {
title: i18n.translate('dataViews.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
defaultMessage: 'Error fetching fields for data view {title} (ID: {id})',
values: { id, title },
}),
});
Expand Down Expand Up @@ -483,7 +483,7 @@ export class DataViewsService {
} else {
this.onError(err, {
title: i18n.translate('dataViews.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
defaultMessage: 'Error fetching fields for data view {title} (ID: {id})',
values: { id: savedObject.id, title },
}),
});
Expand Down Expand Up @@ -654,7 +654,7 @@ export class DataViewsService {
}
const title = i18n.translate('dataViews.unableWriteLabel', {
defaultMessage:
'Unable to write index pattern! Refresh the page to get the most up to date changes for this index pattern.',
'Unable to write data view! Refresh the page to get the most up to date changes for this data view.',
});

this.onNotification({ title, color: 'danger' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ export const getIndexPatternLoadMeta = (): Omit<
name,
type,
inputTypes: ['null'],
help: i18n.translate('dataViews.indexPatternLoad.help', {
defaultMessage: 'Loads an index pattern',
help: i18n.translate('dataViews.functions.dataViewLoad.help', {
defaultMessage: 'Loads a data view',
}),
args: {
id: {
types: ['string'],
required: true,
help: i18n.translate('dataViews.functions.indexPatternLoad.id.help', {
defaultMessage: 'index pattern id to load',
help: i18n.translate('dataViews.functions.dataViewLoad.id.help', {
defaultMessage: 'data view id to load',
}),
},
},
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data_views/common/lib/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { KbnError } from '../../../kibana_utils/common';
*/
export class DataViewMissingIndices extends KbnError {
constructor(message: string) {
const defaultMessage = "IndexPattern's configured pattern does not match any indices";
const defaultMessage = "Data view's title does not match any indices";

super(
message && message.length ? `No matching indices found: ${message}` : defaultMessage
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/data_views/server/deprecations/scripted_fields.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ export const createScriptedFieldsDeprecationsConfig: (
return [
{
title: i18n.translate('dataViews.deprecations.scriptedFieldsTitle', {
defaultMessage: 'Found index patterns using scripted fields',
defaultMessage: 'Found data views using scripted fields',
}),
message: i18n.translate('dataViews.deprecations.scriptedFieldsMessage', {
defaultMessage: `You have {numberOfIndexPatternsWithScriptedFields} index patterns ({titlesPreview}...) that use scripted fields. Scripted fields are deprecated and will be removed in future. Use runtime fields instead.`,
defaultMessage: `You have {numberOfIndexPatternsWithScriptedFields} data views ({titlesPreview}...) that use scripted fields. Scripted fields are deprecated and will be removed in future. Use runtime fields instead.`,
values: {
titlesPreview: indexPatternTitles.slice(0, PREVIEW_LIMIT).join('; '),
numberOfIndexPatternsWithScriptedFields: indexPatternsWithScriptedFields.length,
Expand All @@ -57,11 +57,11 @@ export const createScriptedFieldsDeprecationsConfig: (
correctiveActions: {
manualSteps: [
i18n.translate('dataViews.deprecations.scriptedFields.manualStepOneMessage', {
defaultMessage: 'Navigate to Stack Management > Kibana > Index Patterns.',
defaultMessage: 'Navigate to Stack Management > Kibana > Data Views.',
}),
i18n.translate('dataViews.deprecations.scriptedFields.manualStepTwoMessage', {
defaultMessage:
'Update {numberOfIndexPatternsWithScriptedFields} index patterns that have scripted fields to use runtime fields instead. In most cases, to migrate existing scripts, you will need to change "return <value>;" to "emit(<value>);". Index patterns with at least one scripted field: {allTitles}',
'Update {numberOfIndexPatternsWithScriptedFields} data views that have scripted fields to use runtime fields instead. In most cases, to migrate existing scripts, you will need to change "return <value>;" to "emit(<value>);". Data views with at least one scripted field: {allTitles}',
values: {
allTitles: indexPatternTitles.join('; '),
numberOfIndexPatternsWithScriptedFields: indexPatternsWithScriptedFields.length,
Expand Down
1 change: 1 addition & 0 deletions src/plugins/data_views/server/saved_objects/data_views.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const dataViewSavedObjectType: SavedObjectsType = {
hidden: false,
namespaceType: 'single',
management: {
displayName: 'Data view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattkime We missed Data view is capitalized and it's displaying an inconsistent list from the categories drop-down in Saved Objects Management:
Screen Shot 2022-03-09 at 4 02 14 PM
Is this something we should fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. its in src/plugins/data_views/server/saved_objects/data_views.ts if you're working on something. Or do you want me to open a PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #127533

icon: 'indexPatternApp',
defaultSearchField: 'title',
importableAndExportable: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ export function Doc(props: DocProps) {
iconType="alert"
title={
<FormattedMessage
id="discover.doc.failedToLocateIndexPattern"
defaultMessage="No index pattern matches ID {indexPatternId}."
id="discover.doc.failedToLocateDataView"
defaultMessage="No data view matches ID {indexPatternId}."
values={{ indexPatternId: indexPattern.id }}
/>
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ export function ChangeIndexPattern({
>
<div style={{ width: 320 }}>
<EuiPopoverTitle>
{i18n.translate('discover.fieldChooser.indexPattern.changeIndexPatternTitle', {
defaultMessage: 'Change index pattern',
{i18n.translate('discover.fieldChooser.indexPattern.changeDataViewTitle', {
defaultMessage: 'Change data view',
})}
</EuiPopoverTitle>
<EuiSelectable<{ value: string }>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ function DiscoverFieldComponent({
iconType="pencil"
data-test-subj={`discoverFieldListPanelEdit-${field.name}`}
aria-label={i18n.translate('discover.fieldChooser.discoverField.editFieldLabel', {
defaultMessage: 'Edit index pattern field',
defaultMessage: 'Edit data view field',
})}
/>
</EuiFlexItem>
Expand All @@ -337,7 +337,7 @@ function DiscoverFieldComponent({
<EuiFlexItem grow={false} data-test-subj="discoverFieldListPanelDeleteItem">
<EuiToolTip
content={i18n.translate('discover.fieldChooser.discoverField.deleteFieldLabel', {
defaultMessage: 'Delete index pattern field',
defaultMessage: 'Delete data view field',
})}
>
<EuiButtonIcon
Expand All @@ -348,7 +348,7 @@ function DiscoverFieldComponent({
data-test-subj={`discoverFieldListPanelDelete-${field.name}`}
color="danger"
aria-label={i18n.translate('discover.fieldChooser.discoverField.deleteFieldLabel', {
defaultMessage: 'Delete index pattern field',
defaultMessage: 'Delete data view field',
})}
/>
</EuiToolTip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function DiscoverIndexPatternManagement(props: DiscoverIndexPatternManage
iconType="boxesHorizontal"
data-test-subj="discoverIndexPatternActions"
aria-label={i18n.translate('discover.fieldChooser.indexPatterns.actionsPopoverLabel', {
defaultMessage: 'Index pattern settings',
defaultMessage: 'Data view settings',
})}
onClick={() => {
setIsAddIndexPatternFieldPopoverOpen(!isAddIndexPatternFieldPopoverOpen);
Expand All @@ -84,7 +84,7 @@ export function DiscoverIndexPatternManagement(props: DiscoverIndexPatternManage
}}
>
{i18n.translate('discover.fieldChooser.indexPatterns.addFieldButton', {
defaultMessage: 'Add field to index pattern',
defaultMessage: 'Add field to data view',
})}
</EuiContextMenuItem>,
<EuiContextMenuItem
Expand All @@ -99,7 +99,7 @@ export function DiscoverIndexPatternManagement(props: DiscoverIndexPatternManage
}}
>
{i18n.translate('discover.fieldChooser.indexPatterns.manageFieldButton', {
defaultMessage: 'Manage index pattern fields',
defaultMessage: 'Manage data view fields',
})}
</EuiContextMenuItem>,
]}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ export function resolveIndexPattern(
}

if (stateVal && !stateValFound) {
const warningTitle = i18n.translate('discover.valueIsNotConfiguredIndexPatternIDWarningTitle', {
defaultMessage: '{stateVal} is not a configured index pattern ID',
const warningTitle = i18n.translate('discover.valueIsNotConfiguredDataViewIDWarningTitle', {
defaultMessage: '{stateVal} is not a configured data view ID',
values: {
stateVal: `"${stateVal}"`,
},
Expand All @@ -117,9 +117,9 @@ export function resolveIndexPattern(
if (ownIndexPattern) {
toastNotifications.addWarning({
title: warningTitle,
text: i18n.translate('discover.showingSavedIndexPatternWarningDescription', {
text: i18n.translate('discover.showingSavedDataViewWarningDescription', {
defaultMessage:
'Showing the saved index pattern: "{ownIndexPatternTitle}" ({ownIndexPatternId})',
'Showing the saved data view: "{ownIndexPatternTitle}" ({ownIndexPatternId})',
values: {
ownIndexPatternTitle: ownIndexPattern.title,
ownIndexPatternId: ownIndexPattern.id,
Expand All @@ -131,9 +131,9 @@ export function resolveIndexPattern(

toastNotifications.addWarning({
title: warningTitle,
text: i18n.translate('discover.showingDefaultIndexPatternWarningDescription', {
text: i18n.translate('discover.showingDefaultDataViewWarningDescription', {
defaultMessage:
'Showing the default index pattern: "{loadedIndexPatternTitle}" ({loadedIndexPatternId})',
'Showing the default data view: "{loadedIndexPatternTitle}" ({loadedIndexPatternId})',
values: {
loadedIndexPatternTitle: loadedIndexPattern.title,
loadedIndexPatternId: loadedIndexPattern.id,
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/discover/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const getUiSettings: () => Record<string, UiSettingsParams> = () => ({
type: 'select',
description: i18n.translate('discover.advancedSettings.sortDefaultOrderText', {
defaultMessage:
'Controls the default sort direction for time based index patterns in the Discover app.',
'Controls the default sort direction for time based data views in the Discover app.',
}),
category: ['discover'],
schema: schema.oneOf([schema.literal('desc'), schema.literal('asc')]),
Expand Down Expand Up @@ -150,7 +150,7 @@ export const getUiSettings: () => Record<string, UiSettingsParams> = () => ({
description: i18n.translate('discover.advancedSettings.context.tieBreakerFieldsText', {
defaultMessage:
'A comma-separated list of fields to use for tie-breaking between documents that have the same timestamp value. ' +
'From this list the first field that is present and sortable in the current index pattern is used.',
'From this list the first field that is present and sortable in the current data view is used.',
}),
category: ['discover'],
schema: schema.arrayOf(schema.string()),
Expand All @@ -174,11 +174,11 @@ export const getUiSettings: () => Record<string, UiSettingsParams> = () => ({
},
[MODIFY_COLUMNS_ON_SWITCH]: {
name: i18n.translate('discover.advancedSettings.discover.modifyColumnsOnSwitchTitle', {
defaultMessage: 'Modify columns when changing index patterns',
defaultMessage: 'Modify columns when changing data views',
}),
value: true,
description: i18n.translate('discover.advancedSettings.discover.modifyColumnsOnSwitchText', {
defaultMessage: 'Remove columns that are not available in the new index pattern.',
defaultMessage: 'Remove columns that are not available in the new data view.',
}),
category: ['discover'],
schema: schema.boolean(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const allowHiddenAriaLabel = i18n.translate('indexPatternEditor.form.allowHidden
const customIndexPatternIdLabel = i18n.translate(
'indexPatternEditor.form.customIndexPatternIdLabel',
{
defaultMessage: 'Custom index pattern ID',
defaultMessage: 'Custom data view ID',
}
);

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ export const EmptyIndexListPrompt = ({
link: (
<EuiLink onClick={() => createAnyway()} data-test-subj="createAnyway">
<FormattedMessage
id="indexPatternEditor.createIndexPattern.emptyState.createAnywayLink"
defaultMessage="create an index pattern against hidden or system indices."
id="indexPatternEditor.createDataView.emptyState.createAnywayLink"
defaultMessage="create a data view against hidden or system indices."
/>
</EuiLink>
),
Expand Down
Loading