[ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled #110053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/apm-ui (Team:apm) |
This reverts commit ca86f76.
|
Sorry, unintended ping of the APM team, removed related code and labels. |
peteharverson
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
LGTM.
Leaving #97269 open as eventually it would be good to get the full interaction for the header cells as you have when the histograms are not enabled:
cchaos
reviewed
Aug 26, 2021
Comment on lines
+6
to
+7
| // Override to align the sorting arrow at the bottom when histogram charts are enabled | ||
| .euiDataGridHeaderCell .euiDataGridHeaderCell__sortingArrow { |
There was a problem hiding this comment.
Can you make a request in EUI to allow passing a custom class name to the EuiDataGridHeaderCell?
There was a problem hiding this comment.
I added an issue in EUI here: elastic/eui#5106
We'd like to get this in 7.15 do you think there will be another EUI fix release that could include this or are you fine with merging this and we keep track of an EUI update to resolve this later?
There was a problem hiding this comment.
It's not considered something we'd usually backport for. Do what you need to do.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 27, 2021
…are enabled (elastic#110053) Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 27, 2021
…are enabled (elastic#110053) Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.
kibanamachine
added a commit
that referenced
this pull request
Aug 28, 2021
…are enabled (#110053) (#110415) Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled. Co-authored-by: Walter Rafelsberger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 28, 2021
…are enabled (#110053) (#110416) Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled. Co-authored-by: Walter Rafelsberger <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 30, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (120 commits) [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218) skip flaky suite (elastic#98463) skip flaky suite (elastic#108633) [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903) fixes failing tests (elastic#110436) [TSVB] Remove deprecated `IFieldType` (elastic#110404) [Lens] Remove deprecated `IFieldType` (elastic#109825) [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023) [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031) [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914) Don't add split part of UI if we have one series (elastic#109483) [Discover] Migrate angular routing to react router (elastic#107042) [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282) [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053) [canvas] Fix image argument form issues (elastic#109767) Fix asset in Pitch template (elastic#109742) chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265) chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269) [Fleet] Fix upgrade link in Fleet policy table (elastic#110228) [ML] APM Latency Correlations: Fix empty state (elastic#109813) ... # Conflicts: # src/plugins/data/common/query/timefilter/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #97269.
Adds a CSS override to align the sorting arrow at the bottom when histogram charts are enabled.
Before:
After:
Checklist