Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled #110053

Merged
merged 4 commits into from
Aug 27, 2021
Merged

[ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled #110053

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca86f76
[ML] Fix tooltip text.
walterra Aug 24, 2021
1ff06ec
[ML] Override to align the sorting arrow at the bottom when histogram…
walterra Aug 25, 2021
5650ad7
Revert "[ML] Fix tooltip text."
walterra Aug 25, 2021
1f25ad7
Merge branch 'master' into ml-data-grid-fix-sorting-icon-position
kibanamachine Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions x-pack/plugins/ml/public/application/components/data_grid/data_grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,10 @@
.euiDataGridRowCell--boolean {
text-transform: none;
}

// Override to align the sorting arrow at the bottom when histogram charts are enabled
.euiDataGridHeaderCell .euiDataGridHeaderCell__sortingArrow {
Comment on lines +6 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a request in EUI to allow passing a custom class name to the EuiDataGridHeaderCell?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an issue in EUI here: elastic/eui#5106
We'd like to get this in 7.15 do you think there will be another EUI fix release that could include this or are you fine with merging this and we keep track of an EUI update to resolve this later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not considered something we'd usually backport for. Do what you need to do.

margin-top: auto;
margin-bottom: 0;
}
}