[8.11] [ML] AIOps: Fix Change point embeddable reporting (#169962) #170046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes elastic#169733 #### Reporting fix Change point detection embeddable was incorrectly reporting render completion. It was relying on the `onLoad` callback from the Lens embeddable responsible for chart rendering, which only indicates that data fetching is complete, but not the actual rendering. Current implementation relies on the `renderComplete` event from each child embeddable. Both PNG and PDF exports tested and work as expected.  #### Additional fixes - Fixes the metric and split field controls states when editing existing Change point embeddable from a dashboard - Fixes `filter` query if partitions input is initialized as an empty array. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 80d382a) # Conflicts: # .eslintrc.js
1 task
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @darnautov |
walterra
reviewed
Oct 30, 2023
| @@ -248,6 +249,7 @@ const FieldPanel: FC<FieldPanelProps> = ({ | |||
| disabled: removeDisabled, | |||
| }, | |||
| ], | |||
| 'data=test-subj': 'aiopsChangePointDetectionContextMenuPanel', | |||
There was a problem hiding this comment.
The = should be - I guess?
There was a problem hiding this comment.
Agreed with @darnautov to fix in a separate PR as this needs correcting on main too, and this data-test-subj is not currently being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:Questions ?
Please refer to the Backport tool documentation