Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [ML] AIOps: Fix Change point embeddable reporting (#169962) #170046

Merged
merged 1 commit into from
Oct 30, 2023

Commits on Oct 27, 2023

  1. [ML] AIOps: Fix Change point embeddable reporting (elastic#169962)

    ## Summary
    
    Fixes elastic#169733
    
    #### Reporting fix
    
    Change point detection embeddable was incorrectly reporting render
    completion. It was relying on the `onLoad` callback from the Lens
    embeddable responsible for chart rendering, which only indicates that
    data fetching is complete, but not the actual rendering. Current
    implementation relies on the `renderComplete` event from each child
    embeddable. Both PNG and PDF exports tested and work as expected.
    
    ![DASHBOARDDDD](https://github.com/elastic/kibana/assets/5236598/fb718f31-5862-43ab-82e3-60ebb795b8eb)
    
    #### Additional fixes
    
    - Fixes the metric and split field controls states when editing existing
    Change point embeddable from a dashboard
    - Fixes `filter` query if partitions input is initialized as an empty
    array.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    (cherry picked from commit 80d382a)
    
    # Conflicts:
    #	.eslintrc.js
    darnautov committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e2c6bff View commit details
    Browse the repository at this point in the history