Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Reenable and stabilize APM correlations API integration tests. #187444

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[APM] Reenable and stabilize APM correlations API integration tests. #187444

merged 1 commit into from
Jul 3, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 3, 2024 •
edited
Loading

Summary

Fixes #176544.
Fixes #187421.
Fixes #176119.
Fixes #176425.
Fixes #175855.
Fixes #175911.
Fixes #176780.

Follow up to #186182.

Reenables and stabilizes APM correlations API integration tests.

Review hint: View with the w=1 flag to ignore whitespace changes: https://github.com/elastic/kibana/pull/187444/files?w=1

Checklist

@walterra walterra added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jul 3, 2024
@walterra walterra self-assigned this Jul 3, 2024
@walterra walterra requested a review from a team as a code owner July 3, 2024 08:04
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 3, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @walterra

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6454

[✅] x-pack/test/apm_api_integration/trial/config.ts: 50/50 tests passed.

see run history

MiriamAparicio
MiriamAparicio approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @walterra for fixing the tests

@peteharverson peteharverson mentioned this pull request Jul 3, 2024
Closed
13 tasks
@walterra walterra merged commit 39d3e1a into elastic:main Jul 3, 2024
28 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 3, 2024
@walterra walterra deleted the ml-apm-correlation-fix-api-integration-tests branch July 3, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/p_values.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0" Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/failed_transactions.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0" Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/field_value_pairs.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0" Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/field_candidates.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0" Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/latency.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0"
Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/index·ts - APM API tests correlations/significant_correlations.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0" Failing test: APM API Integration tests (trial).x-pack/test/apm_api_integration/tests/correlations/field_candidates·spec·ts - APM API tests correlations/field_candidates.spec.ts trial no archive field candidates without data handles the empty state
4 participants
@walterra @elasticmachine @kibanamachine @MiriamAparicio