[ML] Increase Test Coverage 8.15.0 #182235
Comments
peteharverson
assigned walterra, darnautov, alvarezmelissa87, peteharverson and jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
2 tasks
darnautov
added a commit
that referenced
this issue
May 7, 2024
…ting rule (#182565) ## Summary Part of #182235 Adds functional tests for the Advanced settings section in the anomaly detection rule flyout. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
10 tasks
qn895
added a commit
that referenced
this issue
Jun 2, 2024
…ntains ML module and transform (#184553) ## Summary Part of #182235. This PR adds a new cypress test in Fleet that: 1) Installs the `lmd` integration package, which contains a ML module and a transform 2) Verify in the Assets page that the elasticsearch destination index for the transform, index template (composed of `@package` and `@custom`), component templates (`@package`) exists, transform, and ML module exists 3) Navigate to each of the asset and verify that they are healthy/empty as expected. For transform, verify using API. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]>
Merged
2 tasks
1 task
darnautov
added a commit
that referenced
this issue
Jul 10, 2024
…oint (#187865) ## Summary Part of #182235 Adds API integration tests for the `GET /internal/ml/trained_models/model_downloads` endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jul 10, 2024
…oint (elastic#187865) ## Summary Part of elastic#182235 Adds API integration tests for the `GET /internal/ml/trained_models/model_downloads` endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 48d4d9e)
kibanamachine
added a commit
that referenced
this issue
Jul 10, 2024
…nloads` endpoint (#187865) (#187940) # Backport This will backport the following commits from `main` to `8.15`: - [[ML] API integration tests for `/trained_models/model_downloads` endpoint (#187865)](#187865) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-10T09:01:24Z","message":"[ML] API integration tests for `/trained_models/model_downloads` endpoint (#187865)\n\n## Summary\r\n\r\nPart of #182235\r\n\r\nAdds API integration tests for the `GET\r\n/internal/ml/trained_models/model_downloads` endpoint\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"48d4d9ed2c67771a7746422a9203d0008b52b6f9","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","test-api-integration","Team:ML","v8.15.0","v8.16.0"],"title":"[ML] API integration tests for `/trained_models/model_downloads` endpoint","number":187865,"url":"https://github.com/elastic/kibana/pull/187865","mergeCommit":{"message":"[ML] API integration tests for `/trained_models/model_downloads` endpoint (#187865)\n\n## Summary\r\n\r\nPart of #182235\r\n\r\nAdds API integration tests for the `GET\r\n/internal/ml/trained_models/model_downloads` endpoint\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"48d4d9ed2c67771a7746422a9203d0008b52b6f9"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187865","number":187865,"mergeCommit":{"message":"[ML] API integration tests for `/trained_models/model_downloads` endpoint (#187865)\n\n## Summary\r\n\r\nPart of #182235\r\n\r\nAdds API integration tests for the `GET\r\n/internal/ml/trained_models/model_downloads` endpoint\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"48d4d9ed2c67771a7746422a9203d0008b52b6f9"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
pgayvallet
pushed a commit
to pgayvallet/kibana
that referenced
this issue
Jul 11, 2024
…oint (elastic#187865) ## Summary Part of elastic#182235 Adds API integration tests for the `GET /internal/ml/trained_models/model_downloads` endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
34 tasks
alvarezmelissa87
added a commit
that referenced
this issue
Jul 16, 2024
…maly action menu (#187801) ## Summary Related meta issue #182235 - Adds tests for click action on anomaly markers in the single metric viewer embeddable ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Elastic Machine <[email protected]>
|
Closing as all items planned for 8.15 have been completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up to #178111
Meta issue to summarize improvements to test coverage for
8.15.0.Jest unit tests
API integration tests
GET /internal/ml/info(JG) [ML] API test for ML info endpoint #187474GET /internal/ml/ml_node_count(JG) [ML] API test for ml_node_count #187484GET /internal/ml/datafeeds/:datafeedId/_preview(JG) [ML] API test for datafeed preview #187499GET /internal/ml/trained_models/model_downloads(DA) [ML] API integration tests for/trained_models/model_downloadsendpoint #187865Serverless tests
Functional tests
Accessibility tests
part of #88496
The text was updated successfully, but these errors were encountered: