Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] API test for datafeed preview #187499

Merged
merged 4 commits into from
Jul 4, 2024
Merged

[ML] API test for datafeed preview #187499

merged 4 commits into from
Jul 4, 2024

Conversation

jgowdyelastic
Copy link
Member

Tests for /internal/ml/datafeeds/<datafeedId>/_preview

@jgowdyelastic
Copy link
Member Author

/ci

@jgowdyelastic jgowdyelastic self-assigned this Jul 3, 2024
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jul 3, 2024
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 3, 2024
Closed
13 tasks
@jgowdyelastic jgowdyelastic marked this pull request as ready for review July 3, 2024 16:35
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 3, 2024 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / useGetChoices calls the api when invoked with the correct parameters

Metrics [docs]

✅ unchanged

History

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 0c71de8 into elastic:main Jul 4, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgowdyelastic @elasticmachine @peteharverson @kibanamachine