Dependable agg ids #1931
Merged
Dependable agg ids #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 13, 2014 14:49
|
As far as I can tell everything works... LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign ids to AggConfig objects that are unique to the list of aggConfigs. Previously, the ids were chosen by lodash every time an aggConfig was created (which includes every time a vis was "rehydrated" from state). Now, we persist the ids in the aggConfig state and get new ids by adding 1 to the max id of all sibling aggConfigs.
The only new behavior that should be different after this change is the way that colors are assigned to aggregations in the visualize app. When opening in the app, then moving to a different app, and coming back, the colors assigned to the visualization won't change. Fixes #1767
Prereq for #1536 : The reason this was completed is to make sorting by one of many metric aggs possible, which requires a relationship to be defined between two aggs. The simplest way to do this is with ids, but those ids needed to persist.