Create vendor dll for the client modules #22618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Verified plugin install containing a dependency not in Kibana. Install time went from 276s to 161s, a 41.6% reduction. 👏 |
|
oh yeah! @tylersmalley do you think we are good to go? |
spalger
approved these changes
Dec 4, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
|
6.x: 42102ba |
tylersmalley
pushed a commit
that referenced
this pull request
Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by #22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by elastic#22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by elastic#22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
tylersmalley
added a commit
that referenced
this pull request
Jan 22, 2019
tylersmalley
added a commit
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives kibana the ability of use webpack dlls for the used
node_modulesby the client. It has a lot of positive sides including for example the ability to just delete every node_module already bundled into the dll from our final distributionnode_modulespath (but there are a lot of others).All the work stages, goals/benefits and results are listed in the following issue #20749. Please take a look in order to get more info.
Additionally this PR also extends the current watch optimizer cache, achieved by #2417 . With this extension the watch optimizer cache invalidation would also be responsible for delete the DLL bundle automatically as soon as it becomes stale.
I wanna thanks to everyone that help me through this journey specially to @spalger, @tylersmalley and ofc my sweet @elastic/kibana-operations team.