Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude all x-pack workspaces from OSS builds #29124

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jan 22, 2019

Summary

Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by #22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @joshdover

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@tylersmalley tylersmalley merged commit 72c2f78 into elastic:master Jan 22, 2019
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by elastic#22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by elastic#22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
@joshdover joshdover deleted the fx-oss-build branch January 22, 2019 19:10
tylersmalley added a commit that referenced this pull request Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by #22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
tylersmalley added a commit that referenced this pull request Jan 22, 2019
Filters out any x-pack workspaces from OSS builds. Fixes an issue introduced by #22618 that was causing the Infra plugin code to be included in the node_modules for OSS builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v6.6.0 v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants