Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percentile Agg #2486

Merged
merged 41 commits into from
Jan 9, 2015
Merged

Percentile Agg #2486

merged 41 commits into from
Jan 9, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 30, 2014

  • Adds the percentile agg as a first aggregation that provides multiple metric values.
  • aggType objects now extend the Bucket/MetricAggType classes
  • aggTypes now read their own values from buckets: count, percentiles and all others read the values differently
  • aggConfig objects are considered "request" aggConfig a by default and can have different or multiple "response" aggConfigs
    • response metric aggs will all be pulled from the same bucket
    • getResponseConfigClass module creates a temporary class that extends the agg config instance to allow mimicking the agg config but overriding specific properties (like make label and id)
    • sidebar in visualize now uses inherited scopes all the way through
    • added $scope.$watchMulti syntaxes to support $watchCollection and deep object equality more info
    • added $scope.$bind for isolate scope-like two-way binding of parent scope values

Spencer Alger added 12 commits December 29, 2014 20:12
Merge remote-tracking branch 'pr/default-values' into multiValueMetri…
89a30bc 
…cAggs
[aggTypes] split metric aggs into files
2973aea
[discover] clear fetchStatus when the fetch is complete
b280030
[aggTypes] update aggTypes to use new Bucket/MetricAggType classes
c31d079
[tabify] [aggTypes/metrics] let the aggType get the metric values
9173cbb
[tabify] allow replacing an agg with other aggs
bfbb4a5
[aggTypes/metrics] setup the percentile aggType
043633e
Merge branch 'list_input_directive' into multiValueMetricAggs
8ac4197
switch to pecent-list
feb0d13
Merge branch 'ordinalSuffix' into multiValueMetricAggs
4cfff47
[aggTypes/percentiles] use ordinalSuffix util for better labels
4b14f0c
Merge branch 'orderTermsOnMetric' into multiValueMetricAggs
ee4002c 
Conflicts:
	src/kibana/components/agg_types/buckets/terms.js
	src/kibana/plugins/visualize/editor/agg.js
@spalger spalger mentioned this pull request Jan 5, 2015
Closed
4 tasks
Spencer Alger added 8 commits January 4, 2015 21:48
@rashidkpc
Copy link
Contributor

There seems to be a bunch of related changes here. Can you expand on the pull request description with the major highlights of the changes?

@spalger spalger assigned spalger and unassigned rashidkpc Jan 8, 2015
@w33ble
Copy link
Contributor

w33ble commented Jan 8, 2015

img

w33ble
w33ble reviewed Jan 8, 2015
View reviewed changes
src/kibana/components/watch_multi.js
@@ -20,31 +39,53 @@ define(function (require) {
if (!_.isFunction(fn)) throw new TypeError('expexted a function that is triggered on each watch');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"expected"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnukz

@spalger spalger assigned rashidkpc and unassigned spalger Jan 9, 2015
rashidkpc added a commit that referenced this pull request Jan 9, 2015
@rashidkpc
Merge pull request #2486 from spenceralger/multiValueMetricAggs
c7e1164 
Percentile Agg
@rashidkpc rashidkpc merged commit c7e1164 into elastic:master Jan 9, 2015
@w33ble w33ble mentioned this pull request Jan 22, 2015
Closed
@spalger spalger deleted the multiValueMetricAggs branch February 9, 2015 20:27
@lukasolson lukasolson mentioned this pull request Sep 25, 2024
Merged
lukasolson added a commit that referenced this pull request Sep 27, 2024
@lukasolson
Fix AggConfig backslash escaping (#193932)
9916dd0 
## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
#2486.)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
@lukasolson
Fix AggConfig backslash escaping (elastic#193932)
2a5ead7 
## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
elastic#2486.)

(cherry picked from commit 9916dd0)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
@lukasolson
Fix AggConfig backslash escaping (elastic#193932)
6f44eae 
## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
elastic#2486.)

(cherry picked from commit 9916dd0)
kibanamachine added a commit that referenced this pull request Sep 27, 2024
@kibanamachine @lukasolson
[8.x] Fix AggConfig backslash escaping (#193932) (#194324)
6040c6e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix AggConfig backslash escaping
(#193932)](#193932)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lukas
Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T15:56:48Z","message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Aggregations","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","backport:prev-major","v8.16.0"],"title":"Fix
AggConfig backslash
escaping","number":193932,"url":"https://github.com/elastic/kibana/pull/193932","mergeCommit":{"message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193932","number":193932,"mergeCommit":{"message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lukas Olson <[email protected]>
angorayc pushed a commit to angorayc/kibana that referenced this pull request Oct 1, 2024
@lukasolson @angorayc
Fix AggConfig backslash escaping (elastic#193932)
986d13a 
## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
elastic#2486.)
neptunian pushed a commit to neptunian/kibana that referenced this pull request Oct 1, 2024
@kibanamachine @lukasolson @neptunian
[8.x] Fix AggConfig backslash escaping (elastic#193932) (elastic#194324)
185247a 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix AggConfig backslash escaping
(elastic#193932)](elastic#193932)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lukas
Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T15:56:48Z","message":"Fix
AggConfig backslash escaping (elastic#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com/elastic/pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Aggregations","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","backport:prev-major","v8.16.0"],"title":"Fix
AggConfig backslash
escaping","number":193932,"url":"https://github.com/elastic/kibana/pull/193932","mergeCommit":{"message":"Fix
AggConfig backslash escaping (elastic#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com/elastic/pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193932","number":193932,"mergeCommit":{"message":"Fix
AggConfig backslash escaping (elastic#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com/elastic/pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lukas Olson <[email protected]>
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Oct 2, 2024
@lukasolson @seanrathier
Fix AggConfig backslash escaping (elastic#193932)
94b290e 
## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
elastic#2486.)
kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @lukasolson
[8.15] Fix AggConfig backslash escaping (#193932) (#194323)
3655b71 
# Backport

This will backport the following commits from `main` to `8.15`:
- [Fix AggConfig backslash escaping
(#193932)](#193932)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lukas
Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T15:56:48Z","message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Aggregations","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","backport:prev-major","v8.16.0"],"title":"Fix
AggConfig backslash
escaping","number":193932,"url":"https://github.com/elastic/kibana/pull/193932","mergeCommit":{"message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193932","number":193932,"mergeCommit":{"message":"Fix
AggConfig backslash escaping (#193932)\n\n## Summary\r\n\r\nFixes
`AggConfig` handling to properly escape backslash as well as
the\r\nsingle quote it already escapes.\r\n\r\n(I believe this has been
around ever
since\r\nhttps://github.com//pull/2486.)","sha":"9916dd0137a87ee9969b3a8d42bbf40cb753dae5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Lukas Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rashidkpc rashidkpc

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @rashidkpc @w33ble