[Vis: Default editor] EUIficate agg-select #31892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
commented
Feb 26, 2019
timroes
reviewed
Feb 26, 2019
29 tasks
|
FYI, I've got a PR up in EUI that will create this pattern of appending nodes to EuiFormRow labels. It's known that you shouldn't put clickable elements inside of |
timroes
reviewed
Feb 27, 2019
|
The |
timroes
suggested changes
Feb 27, 2019
src/legacy/ui/public/vis/editors/default/vis_editor_agg_select/vis_editor_agg_select.tsx
Outdated
Show resolved
Hide resolved
src/legacy/ui/public/vis/editors/default/vis_editor_agg_select/vis_editor_agg_select.tsx
Outdated
Show resolved
Hide resolved
src/legacy/ui/public/vis/editors/default/vis_editor_agg_select/vis_editor_agg_select.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
3 tasks
💚 Build Succeeded |
dmlemeshko
approved these changes
Mar 26, 2019
💚 Build Succeeded |
cchaos
approved these changes
Mar 27, 2019
timroes
approved these changes
Mar 28, 2019
timroes
added
the
release_note:skip
💚 Build Succeeded |
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Mar 28, 2019
* EUIficate agg-select * Improve validation; update TS * Apply styles for helpLink * Fix unit test * Update functional tests * Adjust comboBox service to chose the item where the text mates exactly * Update vis page object * Add default value for agg * Move aggs grouping function to a separate file * Use labelAppend prop for help link node * Add watcher for aggType to manage to discard changes * Add default value for agg type title * Fix defining selected option when aggType is defined * Fix validation issues * Remove a bootstrap specific class * Change css selector in test * Update according to SASS guidelines * Update functinal comboBox service * Added check for undefined * Add jsdoc for groupAggregationsBy function * Add unit tests for groupAggregationsBy * Move setValidity invocation to DefaultEditorAggSelect component * Wrap setValidity into useEffect due to react warning when select is cleaned at the first time * Move help link definition to select component
maryia-lapata
added a commit
that referenced
this pull request
Mar 28, 2019
* EUIficate agg-select * Improve validation; update TS * Apply styles for helpLink * Fix unit test * Update functional tests * Adjust comboBox service to chose the item where the text mates exactly * Update vis page object * Add default value for agg * Move aggs grouping function to a separate file * Use labelAppend prop for help link node * Add watcher for aggType to manage to discard changes * Add default value for agg type title * Fix defining selected option when aggType is defined * Fix validation issues * Remove a bootstrap specific class * Change css selector in test * Update according to SASS guidelines * Update functinal comboBox service * Added check for undefined * Add jsdoc for groupAggregationsBy function * Add unit tests for groupAggregationsBy * Move setValidity invocation to DefaultEditorAggSelect component * Wrap setValidity into useEffect due to react warning when select is cleaned at the first time * Move help link definition to select component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EUIfication of
agg-selectwitch is a part of Data tab on Default Editor.Part of #30922
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately