Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis: Default editor] EUIficate agg-select #31892

Merged
merged 59 commits into from
Mar 28, 2019
Merged

[Vis: Default editor] EUIficate agg-select #31892

merged 59 commits into from
Mar 28, 2019

Commits on Feb 25, 2019

  1. EUIficate agg-select

    @maryia-lapata
    maryia-lapata committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    2d59c0d View commit details
    Browse the repository at this point in the history

  2. Improve validation; update TS

    @maryia-lapata
    maryia-lapata committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    83d6188 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Move aggHelpLink to agg-params

    @maryia-lapata
    maryia-lapata committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0e14bd9 View commit details
    Browse the repository at this point in the history

  2. Apply styles for helpLink

    @maryia-lapata
    maryia-lapata committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    2488f60 View commit details
    Browse the repository at this point in the history

  3. Look form controller upper

    @maryia-lapata
    maryia-lapata committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    b4286ac View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Fix unit test

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    bd25bce View commit details
    Browse the repository at this point in the history

  2. Update functional tests

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    ea82d07 View commit details
    Browse the repository at this point in the history

  3. Rename component

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    8532799 View commit details
    Browse the repository at this point in the history

  4. Adjust comboBox service to chose the item where the text mates exactly

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    cd7cc7f View commit details
    Browse the repository at this point in the history

  5. Update vis page object

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    0b8d3f5 View commit details
    Browse the repository at this point in the history

  6. Add default value for agg

    @maryia-lapata
    maryia-lapata committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    60a9060 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    e5f7e6a View commit details
    Browse the repository at this point in the history

  2. Refactoring

    @maryia-lapata
    maryia-lapata committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    a2b9558 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @maryia-lapata
    maryia-lapata committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    3303d25 View commit details
    Browse the repository at this point in the history

  4. Move aggs grouping function to a separate file

    @maryia-lapata
    maryia-lapata committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    b104972 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b2ee217 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    2734ddb View commit details
    Browse the repository at this point in the history

  2. Use labelAppend prop for help link node

    @maryia-lapata
    maryia-lapata committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e76df1f View commit details
    Browse the repository at this point in the history

  3. Fix throwing an error by clicking Enter because object from selectedO… 

    …ption is created each render call
    @maryia-lapata
    maryia-lapata committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    454c5d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    36ea5f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    1eeec65 View commit details
    Browse the repository at this point in the history

  2. Add watcher for aggType to manage to discard changes

    @maryia-lapata
    maryia-lapata committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    c0db133 View commit details
    Browse the repository at this point in the history

  3. Remove unused useState

    @maryia-lapata
    maryia-lapata committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9dea5e6 View commit details
    Browse the repository at this point in the history

  4. Add default value for agg type title

    @maryia-lapata
    maryia-lapata committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    1eb50b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    ce67b68 View commit details
    Browse the repository at this point in the history

  2. Fix defining selected option when aggType is defined

    @maryia-lapata
    maryia-lapata committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    6f0908c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    18ae7c0 View commit details
    Browse the repository at this point in the history

  2. Refactoring

    @maryia-lapata
    maryia-lapata committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    37bd492 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    8aeeac6 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. Refactoring

    @maryia-lapata
    maryia-lapata committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    d337648 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    44aab2b View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    d53de37 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    1bdbd81 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    52dfda8 View commit details
    Browse the repository at this point in the history

  5. Update test comment

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    b0c8f53 View commit details
    Browse the repository at this point in the history

  6. Update test

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    5bfe018 View commit details
    Browse the repository at this point in the history

  7. Fix validation issues

    @maryia-lapata
    maryia-lapata committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    45062aa View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c742460 View commit details
    Browse the repository at this point in the history

  2. Remove a bootstrap specific class

    @maryia-lapata
    maryia-lapata committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    62e09a7 View commit details
    Browse the repository at this point in the history

  3. Update comments

    @maryia-lapata
    maryia-lapata committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    9105111 View commit details
    Browse the repository at this point in the history

  4. Refactor validation

    @maryia-lapata
    maryia-lapata committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    39d638d View commit details
    Browse the repository at this point in the history

  5. Change css selector in test

    @maryia-lapata
    maryia-lapata committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    1e0c535 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    2328927 View commit details
    Browse the repository at this point in the history

  2. Update according to SASS guidelines

    @maryia-lapata
    maryia-lapata committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    76d8364 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    8705d0b View commit details
    Browse the repository at this point in the history

  2. Refactoring for form validation

    @maryia-lapata
    maryia-lapata committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    63079c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Update functinal comboBox service

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    35a1f4d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    ae01d9f View commit details
    Browse the repository at this point in the history

  3. Added check for undefined

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    5a8ef6a View commit details
    Browse the repository at this point in the history

  4. Add jsdoc for groupAggregationsBy function

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    a1f7863 View commit details
    Browse the repository at this point in the history

  5. Fix types

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    5f7b8f9 View commit details
    Browse the repository at this point in the history

  6. Add unit tests for groupAggregationsBy

    @maryia-lapata
    maryia-lapata committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0f68ca6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    b112a83 View commit details
    Browse the repository at this point in the history

  2. Move setValidity invocation to DefaultEditorAggSelect component

    @maryia-lapata
    maryia-lapata committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    3bf17e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    4fc0c21 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict

    @maryia-lapata
    maryia-lapata committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    0493053 View commit details
    Browse the repository at this point in the history

  3. Wrap setValidity into useEffect due to react warning when select is c… 

    …leaned at the first time
    @maryia-lapata
    maryia-lapata committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    9ac2062 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. Merge branch 'master' into vis-editor-agg-select

    @maryia-lapata
    maryia-lapata committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    dd4c8b8 View commit details
    Browse the repository at this point in the history

  2. Move help link definition to select component

    @maryia-lapata
    maryia-lapata committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f3d5936 View commit details
    Browse the repository at this point in the history