Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] store mapCenter in embeddable config #33902

Merged
merged 5 commits into from
Mar 28, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 26, 2019

This PR stores the map lat, lon, and zoom in the embeddable configuration so embedded maps can be positioned on Dashboards independent of the original Maps center/zoom.

Saving a Dashboard with a maps embeddable now saves the following under embeddableConfig. This way, the same map saved object can be used in multiple dashboards and saved with different locations in each dashboard

Screen Shot 2019-03-26 at 5 25 31 PM

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.2.0 labels Mar 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese nreese mentioned this pull request Mar 26, 2019
10 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, brings up to feature parity with map vizzes

tested in chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit 7ab080a into elastic:master Mar 28, 2019
@nreese nreese added the release_note:skip Skip the PR/issue when compiling release notes label May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants