Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

renovate · 2019-06-07T17:57:59Z

This PR contains the following updates:

Package	Type	Update	Change
@elastic/eui	dependencies	minor	`11.0.1` -> `11.3.1`

Release Notes

elastic/eui

`v11.3.1`

Compare Source

Bug fixes

Fixed EuiBadge conflicts with providing both iconOnClick and onClick (#1994)
Fixed optional TS definitions for EuiColorPicker onBlur and onFocus callbacks (#1993)
Fixed EuiIcon again so that webpack can build dynamic require contexts (#1998)
Fixed double borders on prepend/append items in EuiFormControlLayout (#1996)
Fixed EuiSuperSelect TS definitions (#1995)

`v11.3.0`

Compare Source

Converted EuiTableRowHeaderCheckbox to TS (#1973)
Added missing TypeScript definition for EuiFieldText's compressed prop (#1977)
Converted EuiTableRowCellCheckbox to TS (#1964)
Updated caniuse-lite version resolution (#1970)
Added a webpack directive for naming icon chunks (#1944)
Added ability to update EuiInMemoryTable sorting prop and remove columns after sorting is applied (#1972)
Added onToggle callback to EuiAccordion (#1974)
Removed options defaultProps value from EuiSuperSelect (#1975)
Removed TSlint and will perform all linting through ESLint (#1950)
Added new component EuiDelayRender (#1876)
Replaced EuiColorPicker with custom, customizable component (#1914)
Added jsx-a11y eslint plugin and rules to match Kibana (#1952)
Changed EuiCopy beforeMessage prop to accept node instead of just string (#1952)

Bug fixes

Fixed environment setup for running test-unit script on Windows (#1971)
Fixed focus on single selection of EuiComboBox (#1965)
Fixed type mismatch between PropType and TypeScript def for EuiGlobalToastList toast title (#1978)
Fixed missing Typescript definition for EuiButton's color="text" option (#1980)
Fixed Prettier formatting lint error in EuiTable TS def file (#1986)
Fixed not clickable button with svg in Safari (#1985)
Fixed EuiToggle pointer events for those using icons only (#1991)

`v11.2.1`

Compare Source

Bug fixes

Fixed type mismatch between PropType and TypeScript def for EuiToast title (#1962)

`v11.2.0`

Compare Source

Converted EuiFormControlLayoutCustomIcon to TS (#1956)
Converted EuiStepNumber to TS (#1893)
Converted EuiFormControlLayoutClearButton to TS (#1922)
Added data-test-subj property to EuiDraggable and EuiDroppable (#1943)
Added type definitions to EuiSuperSelect (#1907)
Updated EuiIcon to use Slack's updated branding (#1954)
Updated compile-icons script to format icon components with Prettier (#1955)

Bug fixes

Addressed a chrome issue where negative letter-spacing can reverse RTL text in SVGs (#1960)

`v11.1.0`

Compare Source

Converted pretty_interval to TS (#1920)
Converted relative_options to TS (#1921)
Added width to EuiFlexItem when gutter in EuiFlexGrid is set to none. (#1941)
Format all JavaScript files with Prettier through ESLint (#1906)
Replaced appSecurityAnalytics in EuiIcon with an updated SVG (#1948)

Bug fixes

Removed unused prop enum of l in EuiButton (#1936)
Fixed EuiSelect browser event inconsistencies by normalizing mouseup propagation (#1926)
Removed children as a required prop for EuiOverlayMask (#1937)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

elasticmachine · 2019-06-07T21:00:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…tic-eui-11.x

spalger · 2019-06-11T23:58:02Z

x-pack/plugins/canvas/public/components/font_picker/font_picker.tsx

@@ -32,7 +31,7 @@ export const FontPicker: FunctionComponent<Props> = props => {
    <EuiSuperSelect
      compressed
      options={displayedFonts.map(font => ({
-        value: font.value,
+        value: font.value as FontValue,


@elastic/kibana-canvas this component states that arbitrary font values are supported, but the props and argument to the onSelect handler states that the value is a FontValue, not that it supports arbitrary strings... Can someone decide if it's better to ignore the fact that this supports arbitrary strings or should we switch away from FontValue for string types?

renovate · 2019-06-11T23:59:51Z

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

spalger · 2019-06-12T00:02:02Z

...dit_role/components/privileges/kibana/space_aware_privilege_section/privilege_space_form.tsx

@@ -145,6 +144,92 @@ export class PrivilegeSpaceForm extends Component<Props, State> {

    const hasSelectedSpaces = this.state.selectedSpaceIds.length > 0;

+    const options = [


@elastic/kibana-security moving the options to their own definition converted the value properties to string types, rather than using their "const" types of 'basePrivilege_custom' | 'basePrivilege_read' | 'basePrivilege_all '. This is necessary because the valueOfSelected prop is receiving a generic string, and the value of these properties and the valueOfSelected prop much match. Alternatively we could update the valueOfSelected prop to get a 'basePrivilege_custom' | 'basePrivilege_read' | 'basePrivilege_all ' value... thoughts?

I'm good with this change - thanks for the explanation @spalger!

spalger · 2019-06-12T00:04:25Z

x-pack/plugins/siem/public/components/timeline/body/column_headers/events_select/index.tsx

@@ -60,7 +56,6 @@ export const EventsSelect = pure<Props>(({ checkState, timelineId }) => {
        itemClassName="eventsSelectItem"
        onChange={noop}
        options={getEventsSelectOptions()}
-        valueOfSelected={''}


@elastic/secops The updates to EuiSuperSelect requires that the value properties of the options prop match the type of valueOfSelected. In this usage the options['value'] prop is of type EventsSelectAction or 'select-all' | 'select-none' | 'select-pinned' | 'select-unpinned' | 'pin-selected' | 'unpin-selected', which '' obviously doesn't meet. Can you please verify that removing this prop doesn't break anything?

Thanks @spalger , I found some other warning from EUI and some test case failed when I was running this branch, should we fix that in this branch as well?

elasticmachine · 2019-06-12T03:15:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-06-12T14:15:05Z

Looks like this work is already in progress in #38262

BTW, renovate will just reopen this pr if it's closed before #38262 is merged

Update dependency @elastic/eui to v11.3.1

33f218d

renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.3.0 v8.0.0 labels Jun 7, 2019

spalger added 2 commits June 11, 2019 16:23

Merge branch 'master' of github.com:elastic/kibana into renovate/elas…

b7a7e37

…tic-eui-11.x

adjust usage of EuiSuperSelect now that types are more strict

80abba6

renovate bot requested review from a team as code owners June 11, 2019 23:55

spalger reviewed Jun 11, 2019

View reviewed changes

spalger reviewed Jun 12, 2019

View reviewed changes

spalger added 2 commits June 11, 2019 17:09

upgrade the renaming usages of eui

64b1de8

restore core-js override, elastic/eui#1982 isn't released yet

580e307

spalger mentioned this pull request Jun 12, 2019

Upgrade EUI to 11.3.2 #38262

Merged

renovate bot changed the title ~~Update dependency @elastic/eui to v11.3.1~~ Update dependency @elastic/eui to v11.3.1 - autoclosed Jun 14, 2019

renovate bot closed this Jun 14, 2019

renovate bot deleted the renovate/elastic-eui-11.x branch June 14, 2019 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

renovate bot commented Jun 7, 2019

elasticmachine commented Jun 7, 2019

spalger Jun 11, 2019

renovate bot commented Jun 11, 2019

spalger Jun 12, 2019

legrego Jun 12, 2019

spalger Jun 12, 2019 •

edited

Loading

angorayc Jun 12, 2019

elasticmachine commented Jun 12, 2019

spalger commented Jun 12, 2019 •

edited

Loading

		@@ -145,6 +144,92 @@ export class PrivilegeSpaceForm extends Component<Props, State> {

		const hasSelectedSpaces = this.state.selectedSpaceIds.length > 0;

		const options = [

Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

Conversation

renovate bot commented Jun 7, 2019

Release Notes

Renovate configuration

elasticmachine commented Jun 7, 2019

💔 Build Failed

Choose a reason for hiding this comment

renovate bot commented Jun 11, 2019

PR has been edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spalger Jun 12, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jun 12, 2019

💔 Build Failed

spalger commented Jun 12, 2019 • edited Loading

spalger Jun 12, 2019 •

edited

Loading

spalger commented Jun 12, 2019 •

edited

Loading