Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a test for catching an issue found in a PR (but not in that PR because it kills kibana ci for another reason) #40826

Closed
wants to merge 2 commits into from
Closed

Adding a test for catching an issue found in a PR (but not in that PR because it kills kibana ci for another reason) #40826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518c4a5
add test
stacey-gammon Jul 11, 2019
a78830a
try the extra wait... though it didn't work on the other one
stacey-gammon Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion test/functional/apps/dashboard/dashboard_filtering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ export default function({ getService, getPageObjects }) {

await dashboardAddPanel.closeAddPanel();

await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();

await PageObjects.dashboard.saveDashboard('filtering test');

await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
await filterBar.addFilter('bytes', 'is', '12345678');
Expand Down Expand Up @@ -115,7 +120,24 @@ export default function({ getService, getPageObjects }) {
});
});

describe('using a pinned filter that excludes all data', () => {
// This is for a specific bug that wasn't caught by our existing tests.
describe('same filter can be re-applied after opening the dashboard back up', async () => {
before(async () => {
await PageObjects.dashboard.loadSavedDashboard('filtering test');

await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
await filterBar.addFilter('bytes', 'is', '12345678');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
});

it('filters on pie charts', async () => {
await pieChart.expectPieSliceCount(0);
});
});

describe('using a pinned filter that excludes all data', async () => {
before(async () => {
await filterBar.toggleFilterPinned('bytes');
await PageObjects.header.waitUntilLoadingHasFinished();
Expand Down