Adding a test for catching an issue found in a PR (but not in that PR because it kills kibana ci for another reason) #40826
Conversation
stacey-gammon
changed the title
💔 Build Failed |
|
possibly hitting #20423 |
|
@nreese or @thomasneirynck ... it seems that this PR consistently hits the #20423 (though only on ci, I can't repro locally). Would this be helpful for coming up with a fix to it? It sounds like because it was difficult to repro a fix never was made. The data for the test does include a heatmap visualization on the dashboard. |
|
thx @stacey-gammon agreed that addressing #20423 is the way to go here. need to take a closer look |
|
The maps issue is upstream #20423 (comment) I followed up with the maintainer and hopefully we can get upstream fix. If not, we'll provide work-around in Kibana (perhaps a fork). |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
stacey-gammon
force-pushed
the
2019-07-10-test-failure-check-not-to-merge
branch
from
3dffefe
to
a78830a
Compare
💚 Build SucceededTo update your PR or re-run it, just comment with: |
In #39126 I hit a bug that wasn't caught with our selenium tests so added one. Apparently the change actually kills ci on master. Pulling it out into a separate PR so as not to block the other PR (which had jest tests added).