Add disk space percentage to node listing #42145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachedout
force-pushed
the
disk_space_percentage
branch
from
2c1971b
to
fde41f1
Compare
💔 Build Failed |
cachedout
force-pushed
the
disk_space_percentage
branch
from
fde41f1
to
350f1f5
Compare
💔 Build Failed |
💔 Build Failed |
chrisronline
suggested changes
Jul 31, 2019
x-pack/legacy/plugins/monitoring/public/components/elasticsearch/node_detail_status/index.js
Outdated
Show resolved
Hide resolved
chrisronline
approved these changes
Jul 31, 2019
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
igoristic
approved these changes
Jul 31, 2019
|
Looks good 👍 |
💚 Build Succeeded |
cachedout
force-pushed
the
disk_space_percentage
branch
from
db23229
to
7747c2d
Compare
💚 Build Succeeded |
|
@cachedout Can you please add version labels and perform any necessary backporting too? |
|
Pinging @elastic/stack-monitoring |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
|
@cachedout Polite bump :) |
cachedout
added a commit
to cachedout/kibana
that referenced
this pull request
Aug 12, 2019
* Add disk space percentage to node listing * Test modification for totalSpace * Fix test mockup * Add totalSpace to fixture * Test fixup * Remove trailing space per review suggestion * More fixture updates * More fixture update * More fixture updates * Update mock * More fixture changes
cachedout
added a commit
that referenced
this pull request
Aug 19, 2019
* Add disk space percentage to node listing * Test modification for totalSpace * Fix test mockup * Add totalSpace to fixture * Test fixup * Remove trailing space per review suggestion * More fixture updates * More fixture update * More fixture updates * Update mock * More fixture changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Stack Monitoring application so that when a user view the overview page for a given Elasticsearch node, they see the amount of disk space that is available both as a raw value and as a percentage of the space available.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers