-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove react references from core OverlayService
apis
#48431
Merged
pgayvallet
merged 27 commits into
elastic:master
from
pgayvallet:kbn-37894-NP-agnostic-overlay-service
Nov 19, 2019
Merged
Changes from 23 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
bb08083
move/rename overlay mount and unmount types from banner to parent module
pgayvallet 0dccba9
migrate openModal / modalService
pgayvallet d6c6bd5
migrate openFlyout / flyout service
pgayvallet dd2e3d3
remove CoreStart export from kibana-react
pgayvallet 390503b
adapt some calls to new signature
pgayvallet 052e39d
updates core doc
pgayvallet 6a38024
adapt new calls
pgayvallet cf6f965
adapt js call
pgayvallet f47fc6d
add flex layout on mountWrapper component to avoid losing scroll on o…
pgayvallet bb1c085
create proper flyout/modal services
pgayvallet 7132dbd
update generated doc
pgayvallet f6f4fbe
update snapshot on data/query_bar
pgayvallet 34ecb11
use ReactNode instead of ReactElement
pgayvallet e55d9c0
rename mountForComponent to reactMount
pgayvallet cfaf20e
Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno…
pgayvallet 2cfde6e
Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno…
pgayvallet 0053270
Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno…
pgayvallet 78b5378
change reactMount usages to toMountPoint
pgayvallet db390cb
remove duplicate MountPoint type in overlays
pgayvallet f08fdfe
remove duplicate mount utilities from overlays
pgayvallet 892bcde
allow to specify custom class name to MountWrapper
pgayvallet 25c332f
Allow to specialize MountPoint on HTMLElement subtypes
pgayvallet d64f550
updates generated doc
pgayvallet e26120b
undeprecates openFlyout/openModal & remove direct subservice access f…
pgayvallet 3ac8feb
adapt toast api to get i18n context from service
pgayvallet 54916e9
use MountPoint instead of inline definition
pgayvallet 0ae0157
Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno…
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
docs/development/core/public/kibana-plugin-public.overlaystart.flyouts.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-public](./kibana-plugin-public.md) > [OverlayStart](./kibana-plugin-public.overlaystart.md) > [flyouts](./kibana-plugin-public.overlaystart.flyouts.md) | ||
|
||
## OverlayStart.flyouts property | ||
|
||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
flyouts: OverlayFlyoutStart; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
docs/development/core/public/kibana-plugin-public.overlaystart.modals.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
||
[Home](./index.md) > [kibana-plugin-public](./kibana-plugin-public.md) > [OverlayStart](./kibana-plugin-public.overlaystart.md) > [modals](./kibana-plugin-public.overlaystart.modals.md) | ||
|
||
## OverlayStart.modals property | ||
|
||
|
||
<b>Signature:</b> | ||
|
||
```typescript | ||
modals: OverlayModalStart; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 0 additions & 70 deletions
70
src/core/public/overlays/__snapshots__/flyout.test.tsx.snap
This file was deleted.
Oops, something went wrong.
64 changes: 0 additions & 64 deletions
64
src/core/public/overlays/__snapshots__/modal.test.tsx.snap
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
@import './banners/index'; | ||
@import './mount_wrapper'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
.kbnOverlayMountWrapper { | ||
display: flex; | ||
flex-direction: column; | ||
height: 100%; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, this stateful import will probably go away. Can we pass this Provider down from the I18n service to future-proof this a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. However, the stateful import is also used in
kibana_react
'stoMountPoint
kibana/src/plugins/kibana_react/public/util/react_mount.tsx
Lines 22 to 40 in e04adbe
Should this be a concern?