[Ingest] Fix GET /enrollment-api-keys/null error #64595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
force-pushed
the
feature-ingest-fix-get-null-enrollment-api-keys
branch
from
f52c9f5
to
37669c4
Compare
nchaulet
force-pushed
the
feature-ingest-fix-get-null-enrollment-api-keys
branch
from
37669c4
to
1d1225a
Compare
…t-fix-get-null-enrollment-api-keys
jfsiii
reviewed
Apr 28, 2020
...k/plugins/ingest_manager/public/applications/ingest_manager/hooks/use_request/use_request.ts
Outdated
Show resolved
Hide resolved
...k/plugins/ingest_manager/public/applications/ingest_manager/hooks/use_request/use_request.ts
Show resolved
Hide resolved
...s/ingest_manager/public/applications/ingest_manager/hooks/use_request/enrollment_api_keys.ts
Outdated
Show resolved
Hide resolved
jfsiii
approved these changes
Apr 28, 2020
..._manager/sections/fleet/agent_list_page/components/agent_enrollment_flyout/key_selection.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Apr 28, 2020
nchaulet
added a commit
that referenced
this pull request
Apr 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 29, 2020
* master: (60 commits) [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) [Uptime] Update uptime ml job id to limit to 64 char (elastic#64394) [Ingest] Fix GET /enrollment-api-keys/null error (elastic#64595) Consolidate cross-cutting concerns between region & coordinate maps in new maps_legacy plugin (elastic#64123) ES UI new platform cleanup (elastic#64332) [Event Log] use @timestamp field for queries (elastic#64391) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #63830
Our
useRequestis not working for request that have dependencies.For the enrollment api keys we fetch the list before fetching one to get the api key value (secret to decrypt).
This was causing a bug and making the following request
GET /enrollment-api-keys/nullI introduce a new
useConditionnalRequesthook to allow to fetch only when we have all the required dependencies to make a request. (I did the same fix for agent config where we have the same bug)