Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate downloading plugin bundles to bootstrap script #64685

Merged
merged 9 commits into from
Apr 29, 2020
Merged

Consolidate downloading plugin bundles to bootstrap script #64685

merged 9 commits into from
Apr 29, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 28, 2020

This PR extracts some of the changes from #64414 to try and get them in separately. These changes stop relying on the core PluginLoader service to download plugin bundles and instead just list all the plugin bundles in the bootstrap.js script. This was already being done for a handful of bundles that were being shared across new platform plugins but is now just being done for all of them. This allows downloading the bundles a little earlier in the lifecycle of the page.

@spalger spalger marked this pull request as ready for review April 28, 2020 19:40
@spalger spalger requested a review from a team as a code owner April 28, 2020 19:40
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.0 v8.0.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

joshdover
joshdover approved these changes Apr 28, 2020
View reviewed changes
src/core/public/plugins/plugin_reader.ts Outdated Show resolved Hide resolved
src/core/public/plugins/plugin_loader.test.ts
);
});

test('`loadPluginBundles` rejects if bundle does attach an initializer to window.__kbnBundles__', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this test is still relevant to plugin_reader

Copy link
Contributor Author

@spalger spalger Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I wrote a handful of tests for the plugin reader in https://github.com/elastic/kibana/pull/64685/files#diff-23bdf9ba33b7dd0b3061fc506c0ccc81

@wylieconlon wylieconlon mentioned this pull request Apr 28, 2020
Merged
1 task
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/event_log/public_api_integration·ts.event_log Event Log public API should support date ranges for events

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:11]         └-: event_log
[00:01:11]           └-> "before all" hook
[00:01:11]           └-: Event Log public API
[00:01:11]             └-> "before all" hook
[00:01:11]             └-> should allow querying for events by Saved Object
[00:01:11]               └-> "before each" hook: global before each
[00:01:11]               │ debg Logging Event for Saved Object a9a9b268-45fa-4566-ac08-7d15d4677b73
[00:01:11]               │ proc [kibana]   log   [00:05:43.820] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: a9a9b268-45fa-4566-ac08-7d15d4677b73 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"a9a9b268-45fa-4566-ac08-7d15d4677b73"}]},"message":"test 2020-04-29T00:05:43.767Z"}
[00:01:11]               │ proc [kibana]   log   [00:05:43.835] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/a9a9b268-45fa-4566-ac08-7d15d4677b73] not found
[00:01:12]               │ proc [kibana]   log   [00:05:44.753] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:01:12]               │ proc [kibana]   log   [00:05:44.754] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:12]               │ debg Logging Event for Saved Object a9a9b268-45fa-4566-ac08-7d15d4677b73
[00:01:12]               │ proc [kibana]   log   [00:05:44.756] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"a9a9b268-45fa-4566-ac08-7d15d4677b73"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:43.767Z","@timestamp":"2020-04-29T00:05:44.753Z","ecs":{"version":"1.5.0"}}
[00:01:12]               │ proc [kibana]   log   [00:05:44.801] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: a9a9b268-45fa-4566-ac08-7d15d4677b73 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"a9a9b268-45fa-4566-ac08-7d15d4677b73"}]},"message":"test 2020-04-29T00:05:43.767Z"}
[00:01:12]               │ proc [kibana]   log   [00:05:44.813] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:12]               │ proc [kibana]   log   [00:05:44.814] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:12]               │ debg calling /api/event_log/event_log_test/a9a9b268-45fa-4566-ac08-7d15d4677b73/_find
[00:01:12]               │ proc [kibana]   log   [00:05:44.816] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"a9a9b268-45fa-4566-ac08-7d15d4677b73"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:43.767Z","@timestamp":"2020-04-29T00:05:44.813Z","ecs":{"version":"1.5.0"}}
[00:01:12]               │ debg --- retry.try error: expected 0 to equal 2
[00:01:13]               │ debg calling /api/event_log/event_log_test/a9a9b268-45fa-4566-ac08-7d15d4677b73/_find
[00:01:13]               └- ✓ pass  (1.7s) "event_log Event Log public API should allow querying for events by Saved Object"
[00:01:13]             └-> should support pagination for events
[00:01:13]               └-> "before each" hook: global before each
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ proc [kibana]   log   [00:05:45.505] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.520] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/2d14deff-be95-437d-a5fc-48b5ca9bf2d4] not found
[00:01:13]               │ proc [kibana]   log   [00:05:45.760] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.762] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ debg Logging Event for Saved Object 2d14deff-be95-437d-a5fc-48b5ca9bf2d4
[00:01:13]               │ proc [kibana]   log   [00:05:45.763] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.761Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ proc [kibana]   log   [00:05:45.904] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.913] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.924] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.935] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.952] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 2d14deff-be95-437d-a5fc-48b5ca9bf2d4 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}]},"message":"test 2020-04-29T00:05:45.458Z"}
[00:01:13]               │ proc [kibana]   log   [00:05:45.955] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.956] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ proc [kibana]   log   [00:05:45.958] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.955Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ proc [kibana]   log   [00:05:45.961] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.961] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ proc [kibana]   log   [00:05:45.963] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.964] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ proc [kibana]   log   [00:05:45.965] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.961Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ proc [kibana]   log   [00:05:45.966] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.963Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ proc [kibana]   log   [00:05:45.968] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.969] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ proc [kibana]   log   [00:05:45.971] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.969Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ proc [kibana]   log   [00:05:45.973] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:13]               │ proc [kibana]   log   [00:05:45.974] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:13]               │ debg calling /api/event_log/event_log_test/2d14deff-be95-437d-a5fc-48b5ca9bf2d4/_find
[00:01:13]               │ proc [kibana]   log   [00:05:45.975] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"2d14deff-be95-437d-a5fc-48b5ca9bf2d4"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:45.458Z","@timestamp":"2020-04-29T00:05:45.973Z","ecs":{"version":"1.5.0"}}
[00:01:13]               │ debg --- retry.try error: expected 0 to equal 6
[00:01:14]               │ debg calling /api/event_log/event_log_test/2d14deff-be95-437d-a5fc-48b5ca9bf2d4/_find
[00:01:14]               │ debg calling /api/event_log/event_log_test/2d14deff-be95-437d-a5fc-48b5ca9bf2d4/_find?per_page=3
[00:01:14]               │ debg calling /api/event_log/event_log_test/2d14deff-be95-437d-a5fc-48b5ca9bf2d4/_find?per_page=3&page=2
[00:01:14]               └- ✓ pass  (1.3s) "event_log Event Log public API should support pagination for events"
[00:01:14]             └-> should support sorting by event end
[00:01:14]               └-> "before each" hook: global before each
[00:01:14]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:14]               │ proc [kibana]   log   [00:05:46.819] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:14]               │ proc [kibana]   log   [00:05:46.831] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/d5a6accb-0904-420b-8c60-0a0048d5c5fb] not found
[00:01:15]               │ proc [kibana]   log   [00:05:47.773] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:01:15]               │ proc [kibana]   log   [00:05:47.774] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:15]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:15]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:15]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:15]               │ debg Logging Event for Saved Object d5a6accb-0904-420b-8c60-0a0048d5c5fb
[00:01:15]               │ proc [kibana]   log   [00:05:47.776] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.773Z","ecs":{"version":"1.5.0"}}
[00:01:15]               │ proc [kibana]   log   [00:05:47.920] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:15]               │ proc [kibana]   log   [00:05:47.929] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:15]               │ proc [kibana]   log   [00:05:47.938] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:15]               │ proc [kibana]   log   [00:05:47.947] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:15]               │ proc [kibana]   log   [00:05:47.957] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:15]               │ proc [kibana]   log   [00:05:47.958] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ proc [kibana]   log   [00:05:47.960] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.957Z","ecs":{"version":"1.5.0"}}
[00:01:15]               │ proc [kibana]   log   [00:05:47.961] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:15]               │ proc [kibana]   log   [00:05:47.962] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ proc [kibana]   log   [00:05:47.964] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:15]               │ proc [kibana]   log   [00:05:47.965] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ proc [kibana]   log   [00:05:47.979] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: d5a6accb-0904-420b-8c60-0a0048d5c5fb {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}]},"message":"test 2020-04-29T00:05:46.762Z"}
[00:01:15]               │ proc [kibana]   log   [00:05:47.982] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.962Z","ecs":{"version":"1.5.0"}}
[00:01:15]               │ proc [kibana]   log   [00:05:47.983] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.964Z","ecs":{"version":"1.5.0"}}
[00:01:15]               │ proc [kibana]   log   [00:05:47.987] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:15]               │ proc [kibana]   log   [00:05:47.989] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ proc [kibana]   log   [00:05:47.991] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.988Z","ecs":{"version":"1.5.0"}}
[00:01:15]               │ proc [kibana]   log   [00:05:47.998] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:15]               │ proc [kibana]   log   [00:05:48.000] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:15]               │ debg calling /api/event_log/event_log_test/d5a6accb-0904-420b-8c60-0a0048d5c5fb/_find?sort_field=event.end&sort_order=desc
[00:01:15]               │ proc [kibana]   log   [00:05:48.002] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"d5a6accb-0904-420b-8c60-0a0048d5c5fb"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:46.762Z","@timestamp":"2020-04-29T00:05:47.999Z","ecs":{"version":"1.5.0"}}
[00:01:16]               │ debg --- retry.try error: expected 0 to equal 6
[00:01:16]               │ debg calling /api/event_log/event_log_test/d5a6accb-0904-420b-8c60-0a0048d5c5fb/_find?sort_field=event.end&sort_order=desc
[00:01:16]               └- ✓ pass  (1.9s) "event_log Event Log public API should support sorting by event end"
[00:01:16]             └-> should support date ranges for events
[00:01:16]               └-> "before each" hook: global before each
[00:01:16]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:16]               │ proc [kibana]   log   [00:05:48.733] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:48.666Z"}
[00:01:16]               │ proc [kibana]   log   [00:05:48.747] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/43cbf400-89ee-46b6-a36d-69adf950197e] not found
[00:01:16]               │ proc [kibana]   log   [00:05:48.780] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object
[00:01:16]               │ proc [kibana]   log   [00:05:48.781] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:16]               │ proc [kibana]   log   [00:05:48.783] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:48.666Z","@timestamp":"2020-04-29T00:05:48.780Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:17]               │ proc [kibana]   log   [00:05:49.977] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:49.989] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:49.999] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:50.008] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.784Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:50.018] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:50.033] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.784Z"}
[00:01:17]               │ proc [kibana]   log   [00:05:50.035] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.036] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.045] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.046] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.049] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.050] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.052] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.052] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.054] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.035Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ proc [kibana]   log   [00:05:50.054] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.045Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ proc [kibana]   log   [00:05:50.054] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.049Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ proc [kibana]   log   [00:05:50.055] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.784Z","@timestamp":"2020-04-29T00:05:50.052Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ proc [kibana]   log   [00:05:50.059] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.059] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.061] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.059Z","ecs":{"version":"1.5.0"}}
[00:01:17]               │ proc [kibana]   log   [00:05:50.062] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:17]               │ proc [kibana]   log   [00:05:50.063] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:17]               │ proc [kibana]   log   [00:05:50.066] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.784Z","@timestamp":"2020-04-29T00:05:50.063Z","ecs":{"version":"1.5.0"}}
[00:01:18]               │ debg Logging Event for Saved Object 43cbf400-89ee-46b6-a36d-69adf950197e
[00:01:19]               │ proc [kibana]   log   [00:05:51.114] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 43cbf400-89ee-46b6-a36d-69adf950197e {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:51.065Z"}
[00:01:19]               │ proc [kibana]   log   [00:05:51.127] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:01:19]               │ proc [kibana]   log   [00:05:51.128] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:01:19]               │ debg calling /api/event_log/event_log_test/43cbf400-89ee-46b6-a36d-69adf950197e/_find
[00:01:19]               │ proc [kibana]   log   [00:05:51.129] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:51.065Z","@timestamp":"2020-04-29T00:05:51.127Z","ecs":{"version":"1.5.0"}}
[00:01:19]               │ debg --- retry.try error: expected 7 to equal 8
[00:01:19]               │ debg calling /api/event_log/event_log_test/43cbf400-89ee-46b6-a36d-69adf950197e/_find
[00:01:19]               │ debg calling /api/event_log/event_log_test/43cbf400-89ee-46b6-a36d-69adf950197e/_find?start=2020-04-29T00:05:49.783Z&end=2020-04-29T00:05:50.065Z
[00:01:19]               │ debg failed to match {"foundEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.035Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.045Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.049Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.784Z","@timestamp":"2020-04-29T00:05:50.052Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.783Z","@timestamp":"2020-04-29T00:05:50.059Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-04-29T00:05:49.784Z","@timestamp":"2020-04-29T00:05:50.063Z","ecs":{"version":"1.5.0"}}],"expectedEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.783Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.784Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"namespace":"default","type":"event_log_test","id":"43cbf400-89ee-46b6-a36d-69adf950197e"}]},"message":"test 2020-04-29T00:05:49.784Z"}]}
[00:01:19]               └- ✖ fail: "event_log Event Log public API should support date ranges for events"
[00:01:19]               │

Stack Trace

{ Error: expected 'test 2020-04-29T00:05:49.784Z' to sort of equal 'test 2020-04-29T00:05:49.783Z'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at forEach (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:179:40)
    at Array.forEach (<anonymous>)
    at assertEventsFromApiMatchCreatedEvents (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:176:19)
    at Context.it (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:138:7)
  actual: 'test 2020-04-29T00:05:49.784Z',
  expected: 'test 2020-04-29T00:05:49.783Z',
  showDiff: true }

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 12362d8 into elastic:master Apr 29, 2020
@spalger spalger mentioned this pull request Apr 29, 2020
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 29, 2020
@spalger
Consolidate downloading plugin bundles to bootstrap script (elastic#6…
e9afa9b 
…4685)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
@gmmorris
Merge branch 'master' into alerting/np-migration
baa97e8 
* master: (60 commits)
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  [Uptime] Update uptime ml job id to limit to 64 char (elastic#64394)
  [Ingest] Fix GET /enrollment-api-keys/null error (elastic#64595)
  Consolidate cross-cutting concerns between region & coordinate maps in new maps_legacy plugin (elastic#64123)
  ES UI new platform cleanup (elastic#64332)
  [Event Log] use @timestamp field for queries (elastic#64391)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
@gmmorris
Merge branch 'alerting/np-migration' into alerting/np-migration-tests
8523508 
* alerting/np-migration: (64 commits)
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
  removed unneeded dep and file
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  ...
spalger pushed a commit that referenced this pull request Apr 29, 2020
[7.x] Consolidate downloading plugin bundles to bootstrap script (#64685
af1d02c 
) (#64725)
@spalger spalger deleted the implement/consolidate-plugin-loading-logic branch August 18, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @kibanamachine @joshdover