[Canvas] Force embeddables to refresh when renderable reevaluated #67133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
poffdeluxe
approved these changes
May 21, 2020
| * Timestamp. Needed to get a different result after each time the expression is evaluated | ||
| * to force a reload of the embeddables internal data | ||
| */ | ||
| generated: number; |
There was a problem hiding this comment.
nit: generatedAt might be a better name here to denote that it's a timestamp
added 4 commits
May 22, 2020 13:20
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
that referenced
this pull request
May 26, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
May 26, 2020
…astic#67133) * Force embeddables to refresh when renderable reevaluated * prettier * Rename generated property Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
May 26, 2020
…astic#67133) * Force embeddables to refresh when renderable reevaluated * prettier * Rename generated property Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
May 26, 2020
…7133) (#67351) * Force embeddables to refresh when renderable reevaluated * prettier * Rename generated property Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
May 26, 2020
…7133) (#67353) * Force embeddables to refresh when renderable reevaluated * prettier * Rename generated property Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We render an element with the result of evaluating it's expression.
If the result is unchanged, then we skip rendering. An embeddables expression result will almost always be the same, even on a workpad refresh. To get around this, we add what is essentially a timestamp on the result of the embeddable expression evaluation. This will ensure a rerender happens, and that re-render will cause a reload of the embeddable data.