Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability & APM do not use elasticsearch client provided via setup contract #67263

Merged
merged 3 commits into from
May 26, 2020

Conversation

mshustov
Copy link
Contributor

Summary

Part of #55397
Required to get rid elasticsearch API usages in setup lifecycle.

@mshustov mshustov added chore release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 25, 2020
@mshustov mshustov requested a review from a team as a code owner May 25, 2020 12:03
@mshustov mshustov requested a review from a team May 25, 2020 12:03
@mshustov mshustov requested review from a team as code owners May 25, 2020 12:03
@mshustov mshustov changed the title Observability use es provided via request handler context Observability use es client provided via request handler context May 25, 2020
@mshustov mshustov changed the title Observability use es client provided via request handler context Observability & APM do not use elasticsearch client provided via setup contract May 25, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit cec99f9 into elastic:master May 26, 2020
@mshustov mshustov deleted the observability-use-context-es branch May 26, 2020 12:52
mshustov added a commit to mshustov/kibana that referenced this pull request May 26, 2020
…p contract (elastic#67263)

* dump prettier version to v2

* use elasticserch client provided via context

* use es client provided from start contract
jloleysens added a commit that referenced this pull request May 26, 2020
…ine-editor

* 'master' of github.com:elastic/kibana: (129 commits)
  [Canvas] Force embeddables to refresh when renderable reevaluated (#67133)
  [Canvas] Better handling navigating to/from canvas (#66407)
  [Ingest pipelines] Fix schema validation for simulate and update routes (#67199)
  do not use es from setup (#67277)
  Auto expand replicas for event log (#67286)
  Observability & APM do not use elasticsearch client provided via setup contract  (#67263)
  Fix privileges check when security is not enabled (#67308)
  add IIS home (#66918)
  [ML] Adding additional job service endpoint tests (#66892)
  [Ingest Manager] Update fleet internal doc with latest flags (#67193)
  [Discover] Deangularize the loading spinner (#67165)
  Add `application.navigateToUrl` core API (#67110)
  Improve indexpattern without timefield functional test (#67031)
  KibanaContext in index pattern managment ui (#66985)
  Fix Azure metrics tutorial inside the App Home/ Add data area (#66901)
  add azure logs home (#66910)
  fix: rum agent should work correctly on new platform (#67037)
  [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898)
  only block registration when appRoute contains the exact basePath (#67125)
  Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
mshustov added a commit that referenced this pull request May 26, 2020
…p contract (#67263) (#67322)

* dump prettier version to v2

* use elasticserch client provided via context

* use es client provided from start contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants