-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Update security overview splash #73050
Conversation
)} | ||
<EuiFlexGroup gutterSize="none" justifyContent="spaceBetween"> | ||
<SidebarFlexItem grow={false}> | ||
{indicesExist !== true ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for platform changes
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@@ -112,7 +112,7 @@ export class DocLinksService { | |||
kibana: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index.html`, | |||
siem: { | |||
guide: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`, | |||
gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/install-siem.html`, | |||
gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like install-siem.html
(previously) linked to Get up and running, and now it links to what appears to be the default Elastic Endpoint Security page.
Would you be willing to confirm that we no longer want to link directly to the "getting started" (i.e. Get up and running
) content?
fill: false, | ||
label: 'Add Elastic Endpoint Security', | ||
onClick: undefined, | ||
url: 'ingestUrl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regards to the behavior of the Add Elastic Endpoint Security
button pictured in the screenshot below:
Perhaps for consistency with the Add data with Elastic Agent
button, the Add Elastic Endpoint Security
button links to the more general Integrations
page pictured in the screenshot below:
Thus, when users click Add Elastic Endpoint Security
, it still requires an additional click on the Elastic Endpoint Security
button, pictured above, to finally arrive at the actual Elastic Endpoint Security
page, pictured in the screenshot below:
As more integrations are added, the Elastic Endpoint Security
button (on the Integrations
page) may be harder to find. It also may not be obvious to users that an addition click is required (on the Integrations
page).
Should the Add Elastic Endpoint Security
button link directly to the Elastic Endpoint Security
page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrew-goldstein I like the idea of the more direct path to the actual Elastic Endpoint Security integration page. The only downside is that a user may not get the context that this is one of many integrations available, but given that they user comes from the "Add Elastic Endpoint Security" button, I think this is a good tradeoff.
I'd like to defer to @bradenlpreston since he's been studying this onboarding workflow and can provide clearer guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caitlinbetz for confirmation:
My opinion - we should link directly to the Endpoint Security integration page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenlpreston @MikePaquette The Elastic Endpoint Security
page displays an error message if a specific version is omitted from the URL, as shown in the screenshot below:
Thus we can't directly link to the Elastic Endpoint Security
page (in this PR) without creating a brittle touch point (with the potential to link to a stale/old version).
Details
On master
, the Elastic Endpoint Security
button in the Ingest Manager
integrations
catalog, shown in the screenshot below...
...has a URL that links to version 0.11.0
of the Elastic Endpoint Security
. Specifically, the URL is:
http://localhost:5601/app/ingestManager#/integrations/detail/endpoint-0.11.0
These version numbers may increment frequently, (it would have linked to 0.9.0
just a few days ago), and they are likely to change at least once every release.
To ensure the link always goes to the current version, the link should be non-version-specific.
As noted above, if we omit the version in the URL, changing it from
http://localhost:5601/app/ingestManager#/integrations/detail/endpoint-0.11.0
to
http://localhost:5601/app/ingestManager#/integrations/detail/endpoint
The non-version-specific Elastic Endpoint Security
page does exist (it's not a 404
), but it displays the following error (in the screenshot below) when the version is omitted from the URL:
The screenshot above illustrates that the page served by the non-version-specific URL "knows about" the current version (0.11.0), but it displays an error.
To ensure this PR is included in the next BC (and doesn't introduce a brittle touch point), we will merge it with the original behavior.
@@ -13575,7 +13575,7 @@ | |||
"xpack.securitySolution.detectionEngine.editRule.errorMsgDescription": "申し訳ありません", | |||
"xpack.securitySolution.detectionEngine.editRule.pageTitle": "ルール設定の編集", | |||
"xpack.securitySolution.detectionEngine.editRule.saveChangeTitle": "変更を保存", | |||
"xpack.securitySolution.detectionEngine.emptyActionPrimary": "セットアップの手順を表示", | |||
"xpack.securitySolution.detectionEngine.emptyActionBeats": "セットアップの手順を表示", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to confirm the following command was run?
node scripts/i18n_check --fix
x-pack/plugins/security_solution/public/overview/components/overview_empty/index.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/empty_page/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/empty_page/index.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/overview/components/overview_empty/index.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates @angorayc! 🙏
I raised a few product-related questions that came up while desk testing. This should be GTG when they are resolved
LGTM 🚀
Yeah, that's current behaviour. @patrykkopycinski raised the same question in our last meeting, and agree that we are going to everything behind the splash page. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
## Summary elastic/endpoint-app-team#591 How to verify: 1. go to: x-pack/test/security_solution_cypress/runner.ts 2. comment line 20 (await esArchiver.load('auditbeat');) 3. in line 25 change cypress:run for cypress:open 4. then in our directory run yarn cypress:run-as-ci when the cypress is open, 5. you can access the Kibana instance in port 5620 with username elastic and password changeme <img width="1674" alt="Screenshot 2020-07-23 at 14 48 34" src="https://user-images.githubusercontent.com/6295984/88294333-04a17c80-ccf4-11ea-861b-75a85d2b8129.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
## Summary elastic/endpoint-app-team#591 How to verify: 1. go to: x-pack/test/security_solution_cypress/runner.ts 2. comment line 20 (await esArchiver.load('auditbeat');) 3. in line 25 change cypress:run for cypress:open 4. then in our directory run yarn cypress:run-as-ci when the cypress is open, 5. you can access the Kibana instance in port 5620 with username elastic and password changeme <img width="1674" alt="Screenshot 2020-07-23 at 14 48 34" src="https://user-images.githubusercontent.com/6295984/88294333-04a17c80-ccf4-11ea-861b-75a85d2b8129.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
## Summary elastic/endpoint-app-team#591 How to verify: 1. go to: x-pack/test/security_solution_cypress/runner.ts 2. comment line 20 (await esArchiver.load('auditbeat');) 3. in line 25 change cypress:run for cypress:open 4. then in our directory run yarn cypress:run-as-ci when the cypress is open, 5. you can access the Kibana instance in port 5620 with username elastic and password changeme <img width="1674" alt="Screenshot 2020-07-23 at 14 48 34" src="https://user-images.githubusercontent.com/6295984/88294333-04a17c80-ccf4-11ea-861b-75a85d2b8129.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ Co-authored-by: Angela Chuang <[email protected]>
## Summary elastic/endpoint-app-team#591 How to verify: 1. go to: x-pack/test/security_solution_cypress/runner.ts 2. comment line 20 (await esArchiver.load('auditbeat');) 3. in line 25 change cypress:run for cypress:open 4. then in our directory run yarn cypress:run-as-ci when the cypress is open, 5. you can access the Kibana instance in port 5620 with username elastic and password changeme <img width="1674" alt="Screenshot 2020-07-23 at 14 48 34" src="https://user-images.githubusercontent.com/6295984/88294333-04a17c80-ccf4-11ea-861b-75a85d2b8129.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ Co-authored-by: Angela Chuang <[email protected]>
Summary
https://github.com/elastic/endpoint-app-team/issues/591
How to verify:
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately