Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution] Update security overview splash (#73050) #73589

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Backports the following commits to 7.x:

## Summary

elastic/endpoint-app-team#591

How to verify:

1. go to: x-pack/test/security_solution_cypress/runner.ts 
2. comment line 20 (await esArchiver.load('auditbeat');) 
3. in line 25 change cypress:run for cypress:open
4. then in our directory run yarn cypress:run-as-ci when the cypress is open,
5. you can access the Kibana instance in port 5620 with username elastic and password changeme


<img width="1674" alt="Screenshot 2020-07-23 at 14 48 34" src="https://user-images.githubusercontent.com/6295984/88294333-04a17c80-ccf4-11ea-861b-75a85d2b8129.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~
- [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)~
- [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: expected 'message' to not equal 'message'
    at Context.eval (http://localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts:686:40)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +2.0KB 7.3MB

page load bundle size

id value diff baseline
core 1.1MB -7.0B 1.1MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit 1308f4e into elastic:7.x Jul 29, 2020
@andrew-goldstein andrew-goldstein deleted the backport/7.x/pr-73050 branch July 29, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants