Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update filter #73350

Merged
merged 11 commits into from
Jul 30, 2020
Merged

[Security Solution] Update filter #73350

merged 11 commits into from
Jul 30, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jul 27, 2020 •
edited
Loading

Summary

This PR is to fix
https://github.com/elastic/siem-team/issues/740 - item 48
and https://github.com/elastic/siem-team/issues/805

It’s because previously we have a filter that filters createBy: Elastic, but seems that it’s not case sensitive.
That’s why when users login as elastic user name, the templates they create are not filtered correctly.
In this PR, I remove this clause and rely on status:immutable or active to distinguished elastic and custom templates

How to verify this PR:

case one - login as elastic user:

  1. go to: x-pack/test/security_solution_cypress/runner.ts
  2. in line 25 change cypress:run to cypress:open
  3. then in our directory run yarn cypress:run-as-ci when the cypress is open,
  4. you can access the Kibana instance in port 5620 with username elastic and password changeme
  5. Download this file timelines_export (2).txt
    and rename it from .txt to .ndjson
  6. import it and see if it filters correctly

case two - login as normal user:

  1. start this branch normally from your local
  2. do step 5 & 6 listed above

@angorayc angorayc requested review from a team as code owners July 27, 2020 20:39
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.9.0 v8.0.0 labels Jul 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -410.0B 7.3MB

page load bundle size

id value diff baseline
securitySolution 869.8KB -210.0B 870.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski
patrykkopycinski approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM! Well done Angela 💪

@angorayc angorayc merged commit e3f536c into elastic:master Jul 30, 2020
@angorayc angorayc mentioned this pull request Jul 30, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Jul 30, 2020
@angorayc @elasticmachine
[Security Solution] Update filter (elastic#73350)
e3e4e92 
* update filter

* fix type errors

* fix unit

Co-authored-by: Elastic Machine <[email protected]>
@angorayc angorayc mentioned this pull request Jul 30, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Jul 30, 2020
@angorayc @elasticmachine
[Security Solution] Update filter (elastic#73350)
ef5faaf 
* update filter

* fix type errors

* fix unit

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'master' into alerting/refresh-on-deletion
d63f1f7 
* master:
  [Vega][Inspector] Request panel should show correct names for requests (elastic#73655)
  [Security Solution] Update filter (elastic#73350)
  TSVB Inaccurate Group By (elastic#73683)
  [Vega][Inspect panel] Write tutorials and reference (elastic#73262)
  [ML] Removing node info check for file data viz import (elastic#73717)
  check that pathname has been updated. ignore other parts (elastic#73689)
  [build] rewrite source as transpiled JS later in the process (elastic#73749)
  Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734)
  skip flaky suite (elastic#69783) (elastic#70043)
  [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588)
  skip failing suite (elastic#58815)
  [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732)
  [DOCS] Changes level offset of monitoring pages (elastic#73573)
  Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662)
  [ML] Transforms/DFA: Change action button size back to 'xs'.
  [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545)
  [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
angorayc added a commit that referenced this pull request Jul 30, 2020
@angorayc @elasticmachine
[Security Solution] Update filter (#73350) (#73782)
cfeed2e 
* update filter

* fix type errors

* fix unit

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
angorayc added a commit that referenced this pull request Jul 30, 2020
@angorayc @elasticmachine
[Security Solution] Update filter (#73350) (#73783)
ebaf0ea 
* update filter

* fix type errors

* fix unit

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibanamachine @patrykkopycinski @MindyRS