Fix Snapshot Restore /policies/indices API endpoint on Cloud #73734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
bug
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@alisonelizabeth This bug only manifests on Cloud so for now I think I just need a review of the code. |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 30, 2020
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 30, 2020
…#73734) * Add leading slash to transport.request path. * Remove unnecessary 'hidden' expand_wildcards option, since 'all' includes hidden indices.
cjcenizal
added a commit
that referenced
this pull request
Jul 30, 2020
cjcenizal
added a commit
that referenced
this pull request
Jul 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 30, 2020
* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)
|
Verified that this is fixed in the latest snapshot on Cloud:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreidan brought to my attention that the "Create Policy" page doesn't load in Kibana 7.9 on Cloud:
Based on discussion with the Platform team, it looks like there's a problem with
transport.requestrequests that leave out the leading slash in the path. This problem was introduced in 7.9.0 via https://github.com/elastic/kibana/pull/68078/files#diff-c6affed5dae6e67cdf3b0428950c4d28R239. Hopefully this will be moot once we migrate to using the new client.Also, Gordon B. pointed out that
allwill include hidden indices, so we don't need to expand wildcards to bothhidden,all.