[ML] DF Analytics: adds functional tests for edit form #73885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
test_ui_functional
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
12 tasks
qn895
reviewed
Jul 30, 2020
|
|
||
| async assertJobMmlEditValue(expectedValue: string) { | ||
| const actualMml = await testSubjects.getAttribute( | ||
| 'mlAnalyticsEditFlyoutmodelMemoryLimitInput', |
There was a problem hiding this comment.
nit: not sure if model is meant to be capitalized but if it's intentional then please disregard this comment
alvarezmelissa87
force-pushed
the
ml-dfanalytics-edit-functional-tests
branch
from
8b6c99a
to
00ad323
Compare
pheyos
requested changes
Aug 3, 2020
x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_table.ts
Outdated
Show resolved
Hide resolved
qn895
approved these changes
Aug 3, 2020
|
LGTM |
pheyos
reviewed
Aug 4, 2020
x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_edit.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_edit.ts
Outdated
Show resolved
Hide resolved
|
Checking test stability in a flaky test runner job... was already done, see PR description. |
alvarezmelissa87
force-pushed
the
ml-dfanalytics-edit-functional-tests
branch
from
a2b564a
to
4157177
Compare
pheyos
reviewed
Aug 5, 2020
x-pack/test/functional/services/ml/data_frame_analytics_table.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/services/ml/data_frame_analytics_edit.ts
Outdated
Show resolved
Hide resolved
pheyos
approved these changes
Aug 5, 2020
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Aug 5, 2020
* add edit analytics functional test * adds edit test service * update edit test wording for clarity * check flyout closes after edit * rename testSubj for consitency
alvarezmelissa87
added a commit
that referenced
this pull request
Aug 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds functional tests for 'edit' functionality.
Flaky test run: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/719/
Flaky test run for updates: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/734/
Flaky test run for final update: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/749/
Checklist
Delete any items that are not applicable to this PR.