Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove "Are you sure" from filter lists #76180

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 27, 2020

Summary

Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some machine learning "delete filter" UI text.

Checklist

Screenshots (Before)

Delete a filter list:

image

Delete multiple filter lists:

image

Screenshots (After)

Delete a filter list:

image

Delete multiple filter lists:

image

@lcawl lcawl added the :ml label Aug 27, 2020
@lcawl lcawl marked this pull request as ready for review August 27, 2020 20:57
@lcawl lcawl requested a review from a team as a code owner August 27, 2020 20:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Aug 27, 2020
@lcawl
Copy link
Contributor Author

lcawl commented Aug 27, 2020

NOTE: The guidelines (https://elastic.github.io/eui/#/layout/modal/guidelines) also show an example like this for the singular case:

Delete pipeline 'mypipeline'?

... so if we want to go that route for "Delete filter list 'myfilterlist'", that's fine by me too.

@lcawl
Copy link
Contributor Author

lcawl commented Aug 31, 2020

@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB -904.0B 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 20cb816 into elastic:master Aug 31, 2020
@lcawl lcawl deleted the delete-filters branch August 31, 2020 17:06
lcawl added a commit to lcawl/kibana that referenced this pull request Aug 31, 2020
@lcawl lcawl removed the v7.11.0 label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants