Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove "Are you sure" from filter lists #76180

Merged
merged 3 commits into from
Aug 31, 2020
Merged

[ML] Remove "Are you sure" from filter lists #76180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1ecdc
Remove unnecessary delete filter text
lcawl Aug 27, 2020
1f48d8e
Fixes jest test
lcawl Aug 27, 2020
c9cbe11
Merge branch 'master' into delete-filters
elasticmachine Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions ...s/components/delete_filter_list_modal/__snapshots__/delete_filter_list_modal.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 2 additions & 13 deletions ...ion/settings/filter_lists/components/delete_filter_list_modal/delete_filter_list_modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class DeleteFilterListModal extends Component {
const title = (
<FormattedMessage
id="xpack.ml.settings.filterLists.deleteFilterListModal.modalTitle"
defaultMessage="Delete {selectedFilterListsLength, plural, one {{selectedFilterId}} other {# filter lists}}"
defaultMessage="Delete {selectedFilterListsLength, plural, one {{selectedFilterId}} other {# filter lists}}?"
values={{
selectedFilterListsLength: selectedFilterLists.length,
selectedFilterId: !!selectedFilterLists.length && selectedFilterLists[0].filter_id,
Expand Down Expand Up @@ -86,18 +86,7 @@ export class DeleteFilterListModal extends Component {
}
buttonColor="danger"
defaultFocusedButton={EUI_MODAL_CONFIRM_BUTTON}
>
<p>
<FormattedMessage
id="xpack.ml.settings.filterLists.deleteFilterListModal.deleteWarningMessage"
defaultMessage="Are you sure you want to delete
{selectedFilterListsLength, plural, one {this filter list} other {these filter lists}}"
values={{
selectedFilterListsLength: selectedFilterLists.length,
}}
/>
</p>
</EuiConfirmModal>
/>
</EuiOverlayMask>
);
}
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12397,7 +12397,6 @@
"xpack.ml.settings.filterLists.deleteFilterListModal.cancelButtonLabel": "キャンセル",
"xpack.ml.settings.filterLists.deleteFilterListModal.confirmButtonLabel": "削除",
"xpack.ml.settings.filterLists.deleteFilterListModal.deleteButtonLabel": "削除",
"xpack.ml.settings.filterLists.deleteFilterListModal.deleteWarningMessage": "{selectedFilterListsLength, plural, one {このフィルダー} other {これらのフィルター}}を削除してよろしいですか？",
"xpack.ml.settings.filterLists.deleteFilterListModal.modalTitle": "{selectedFilterListsLength, plural, one {{selectedFilterId}} other {# フィルターリスト}}の削除",
"xpack.ml.settings.filterLists.deleteFilterLists.deletingErrorMessage": "フィルターリスト {filterListId} の削除中にエラーが発生しました。{respMessage}",
"xpack.ml.settings.filterLists.deleteFilterLists.deletingNotificationMessage": "{filterListsToDeleteLength, plural, one {{filterListToDeleteId}} other {# フィルターリスト}}を削除しています",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12401,7 +12401,6 @@
"xpack.ml.settings.filterLists.deleteFilterListModal.cancelButtonLabel": "取消",
"xpack.ml.settings.filterLists.deleteFilterListModal.confirmButtonLabel": "删除",
"xpack.ml.settings.filterLists.deleteFilterListModal.deleteButtonLabel": "删除",
"xpack.ml.settings.filterLists.deleteFilterListModal.deleteWarningMessage": "是否确定要删除{selectedFilterListsLength, plural, one {此筛选列表} other {这些筛选列表}}",
"xpack.ml.settings.filterLists.deleteFilterListModal.modalTitle": "删除 {selectedFilterListsLength, plural, one {{selectedFilterId}} other {# 个筛选列表}}",
"xpack.ml.settings.filterLists.deleteFilterLists.deletingErrorMessage": "删除筛选列表 {filterListId} 时出错。{respMessage}",
"xpack.ml.settings.filterLists.deleteFilterLists.deletingNotificationMessage": "正在删除 {filterListsToDeleteLength, plural, one {{filterListToDeleteId}} other {# 个筛选列表}}",
Expand Down