Removes archives #86537

MadameSheema · 2020-12-18T21:27:04Z

Summary

In this PR we are deleting all the archives that are not related with data shippers indexes in order to help to stabilise more the test suite.

Also some refactor has been done following up some of the comments of this PR: #86093

…o removes-archives

patrykkopycinski

LGTM

rylnd

This looks amazing! So nice to get rid of all those archives.

I had a few comments about consistency/redundancy, but this was already approved and I'm fine moving some of those tasks to a later PR. If you do want to fix them here, I'm happy to do another quick pass and approve 👍

x-pack/plugins/security_solution/cypress/tasks/common.ts

rylnd · 2020-12-21T18:13:44Z

x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts

-
-    afterEach(() => {
-      esArchiverUnload('alerts');
+      waitForAlertsPanelToBeLoaded();


I'm a little bit wary of moving these steps into a beforeEach because of the fail-fast behavior and potential for false negatives, but I think that the speed and DRYness of this approach make it an acceptable tradeoff.

rylnd · 2020-12-21T18:18:29Z

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules.spec.ts

+    loginAndWaitForPageWithoutDateRange(DETECTIONS_URL);
+    waitForAlertsPanelToBeLoaded();
+    waitForAlertsIndexToBeCreated();
+    createCustomRule(newRule, 'rule1');


💯 this is so much better, it's immediately clear that we're working with four rules in this test.

rylnd · 2020-12-21T18:20:26Z

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules.spec.ts

  });

  after(() => {
-    esArchiverUnload('prebuilt_rules_loaded');
+    cy.clock().invoke('restore');


Nit: this teardown is specific to a single time-traveling test. It would be nice if such tests were isolated in their own context with clock-specific setup/teardown hooks.

x-pack/plugins/security_solution/cypress/integration/fields_browser.spec.ts

rylnd · 2020-12-21T18:27:58Z

x-pack/plugins/security_solution/cypress/README.md


-Remember to clean up the state of the test after its execution.
+Remember to use the `cleanKibana` method before starting the execution of the test


Rather than leaving this as a task for the test writer, we could enforce it as a global beforeEach hook.

Here I'm not 100% sure. There are some cases where using before instead of beforeEach, save us execution time. So we need to take into consideration that if we move that to a global hook, we are going to make our tests more slow. Another reason is because I don't like how Cypress handles right now global hooks.

Anyway, this is a think we can investigate/work in a different PR :)

x-pack/plugins/security_solution/cypress/integration/fields_browser.spec.ts

x-pack/plugins/security_solution/cypress/integration/timeline_creation.spec.ts

x-pack/plugins/security_solution/cypress/integration/value_lists.spec.ts

MadameSheema · 2020-12-22T14:02:37Z

@elasticmachine merge upstream

MadameSheema · 2020-12-22T20:04:57Z

@elasticmachine merge upstream

…o removes-archives

patrykkopycinski · 2020-12-23T10:00:28Z

@elasticmachine merge upstream

patrykkopycinski · 2020-12-27T18:27:38Z

@elasticmachine merge upstream

kibanamachine · 2020-12-27T20:49:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5e44d0d

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	48026	48027	+1

History

💚 Build #96139 succeeded ee296ca
💛 Build #96085 was flaky fcd352a
💔 Build #96066 failed e91583b
💔 Build #95994 failed e42b392
💔 Build #95974 failed c301161

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts Co-authored-by: MadameSheema <[email protected]>

* master: (108 commits) [DOCS] Refreshes Data Visualizer screenshot (elastic#87017) [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001) [securitySolution/cypress] temporarily limit to PRs [AppServices/Examples] Add the example for Reporting integration (elastic#82091) [Build Chromium] Improve git checkout (elastic#83225) Deprecate `services.callCluster` in alerts and actions executors (elastic#86474) [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985) [Lens] Add more chart editor tests based on the debug state (elastic#86750) [Lens] Integrate searchSessionId into Lens app (elastic#86297) skip "pagination updates results and page number" elastic#86975 skip "Custom detection rules" elastic#83772 [logging/json] use merge from kbn/std (elastic#86330) skip network and timeline inspection. elastic#85677, elastic#85678 skip "adds correctly a filter to the global search bar" elastic#86552 [ftr/flags] improve help text (elastic#86971) skip "Fields Browser rendering. elastic#60209 skip "Closes and opens alerts" elastic#83773 [Security Solution] Skip failing Cypress tests (elastic#86967) Removes archives (elastic#86537) [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904) ...

* master: (72 commits) [DOCS] Refreshes Data Visualizer screenshot (elastic#87017) [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001) [securitySolution/cypress] temporarily limit to PRs [AppServices/Examples] Add the example for Reporting integration (elastic#82091) [Build Chromium] Improve git checkout (elastic#83225) Deprecate `services.callCluster` in alerts and actions executors (elastic#86474) [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985) [Lens] Add more chart editor tests based on the debug state (elastic#86750) [Lens] Integrate searchSessionId into Lens app (elastic#86297) skip "pagination updates results and page number" elastic#86975 skip "Custom detection rules" elastic#83772 [logging/json] use merge from kbn/std (elastic#86330) skip network and timeline inspection. elastic#85677, elastic#85678 skip "adds correctly a filter to the global search bar" elastic#86552 [ftr/flags] improve help text (elastic#86971) skip "Fields Browser rendering. elastic#60209 skip "Closes and opens alerts" elastic#83773 [Security Solution] Skip failing Cypress tests (elastic#86967) Removes archives (elastic#86537) [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904) ...

MadameSheema added 13 commits December 16, 2020 08:34

removes signals extra sanity

3d7a451

fixes signals cleaning

b5a0e25

cleans kibana before each test execution

daf466d

upgrades cypress to version 6.1.0

aea2a41

enables cypress execution on jenkins

2ef701a

removes alerts archives

a9c0400

removes timeline alerts archive

b7ad376

custom edition wip

3099793

Merge branch 'master' into removes-archives

99c3688

finishes cleaning

2205516

fixes events viewer

828ab3f

adds missing file

611b5ba

fixes tests

af163ac

MadameSheema force-pushed the removes-archives branch 3 times, most recently from 9e6e6c5 to b6a10d2 Compare December 19, 2020 11:13

fixes typecheck issue

40e4504

MadameSheema force-pushed the removes-archives branch from b6a10d2 to 40e4504 Compare December 19, 2020 16:03

MadameSheema added 4 commits December 19, 2020 20:09

removes archives

e78c001

Merge branch 'master' into removes-archives

7f8aa5f

updates readme

0c4c485

Merge branch 'removes-archives' of github.com:MadameSheema/kibana int…

6704df6

…o removes-archives

MadameSheema requested review from rylnd and patrykkopycinski December 21, 2020 11:43

MadameSheema self-assigned this Dec 21, 2020

MadameSheema added v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 21, 2020

MadameSheema marked this pull request as ready for review December 21, 2020 11:44

Merge branch 'master' into removes-archives

15a87ca

patrykkopycinski approved these changes Dec 21, 2020

View reviewed changes

rylnd reviewed Dec 21, 2020

View reviewed changes

MadameSheema added 3 commits December 22, 2020 10:05

improves clean up

630409d

final clean up

89fe2c0

fixes type check issue

ef8393d

kibanamachine and others added 2 commits December 22, 2020 09:02

Merge branch 'master' into removes-archives

4d2390e

skips failing tests

e42b392

MadameSheema force-pushed the removes-archives branch from c301161 to e42b392 Compare December 22, 2020 16:09

last touches

a8a4570

kibanamachine and others added 3 commits December 22, 2020 15:05

Merge branch 'master' into removes-archives

e91583b

skipping failing tests

1247931

Merge branch 'removes-archives' of github.com:MadameSheema/kibana int…

fcd352a

…o removes-archives

Merge branch 'master' into removes-archives

ee296ca

Merge branch 'master' into removes-archives

5e44d0d

patrykkopycinski merged commit c0d6e12 into elastic:master Dec 28, 2020

patrykkopycinski mentioned this pull request Dec 28, 2020

[7.x] Removes archives (#86537) #86954

Merged

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Dec 28, 2020

Removes archives (elastic#86537)

66c10eb

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Dec 28, 2020

Removes archives (elastic#86537)

1b64f7b

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts

patrykkopycinski mentioned this pull request Dec 28, 2020

[7.11] Removes archives (#86537) #86955

Merged

patrykkopycinski added a commit that referenced this pull request Dec 28, 2020

Removes archives (#86537) (#86955)

8561eaf

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts Co-authored-by: MadameSheema <[email protected]>

patrykkopycinski added a commit that referenced this pull request Dec 28, 2020

Removes archives (#86537) (#86954)

df4e5f9

# Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts Co-authored-by: MadameSheema <[email protected]>

MadameSheema deleted the removes-archives branch July 14, 2021 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes archives #86537

Removes archives #86537

MadameSheema commented Dec 18, 2020 •

edited

Loading

patrykkopycinski left a comment

rylnd left a comment

rylnd Dec 21, 2020

rylnd Dec 21, 2020

rylnd Dec 21, 2020

rylnd Dec 21, 2020

MadameSheema Dec 22, 2020

MadameSheema commented Dec 22, 2020

MadameSheema commented Dec 22, 2020

patrykkopycinski commented Dec 23, 2020

patrykkopycinski commented Dec 27, 2020

kibanamachine commented Dec 27, 2020


		Remember to clean up the state of the test after its execution.
		Remember to use the `cleanKibana` method before starting the execution of the test

Removes archives #86537

Removes archives #86537

Conversation

MadameSheema commented Dec 18, 2020 • edited Loading

Summary

patrykkopycinski left a comment

Choose a reason for hiding this comment

rylnd left a comment

Choose a reason for hiding this comment

rylnd Dec 21, 2020

Choose a reason for hiding this comment

rylnd Dec 21, 2020

Choose a reason for hiding this comment

rylnd Dec 21, 2020

Choose a reason for hiding this comment

rylnd Dec 21, 2020

Choose a reason for hiding this comment

MadameSheema Dec 22, 2020

Choose a reason for hiding this comment

MadameSheema commented Dec 22, 2020

MadameSheema commented Dec 22, 2020

patrykkopycinski commented Dec 23, 2020

patrykkopycinski commented Dec 27, 2020

kibanamachine commented Dec 27, 2020

💚 Build Succeeded

Metrics [docs]

Distributable file count

History

MadameSheema commented Dec 18, 2020 •

edited

Loading