Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix charts grid on the Anomaly Explorer page #86904

Merged
merged 2 commits into from
Dec 24, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Fixes #80682

Removes a threshold for updating the chart's container width

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Dec 23, 2020

Tested and Code LGTM 🎉

Main branch
Screen Shot 2020-12-23 at 11 59 10

PR
Screen Shot 2020-12-23 at 12 01 07

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +67.0B

Distributable file count

id before after diff
default 47265 48025 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 47ce575 into elastic:master Dec 24, 2020
@darnautov darnautov deleted the ML-80682-fix-charts-grid branch December 24, 2020 12:52
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
# Conflicts:
#	x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container_service.js
darnautov added a commit that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
# Conflicts:
#	x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container_service.js
darnautov added a commit that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
darnautov added a commit that referenced this pull request Dec 24, 2020
* [ML] fix AR charts grid items width

* [ML] update test snapshot
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 30, 2020
* master: (108 commits)
  [DOCS] Refreshes Data Visualizer screenshot (elastic#87017)
  [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001)
  [securitySolution/cypress] temporarily limit to PRs
  [AppServices/Examples] Add the example for Reporting integration (elastic#82091)
  [Build Chromium] Improve git checkout (elastic#83225)
  Deprecate `services.callCluster` in alerts and actions executors (elastic#86474)
  [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985)
  [Lens] Add more chart editor tests based on the debug state (elastic#86750)
  [Lens] Integrate searchSessionId into Lens app (elastic#86297)
  skip "pagination updates results and page number" elastic#86975
  skip "Custom detection rules" elastic#83772
  [logging/json] use merge from kbn/std (elastic#86330)
  skip network and timeline inspection. elastic#85677, elastic#85678
  skip "adds correctly a filter to the global search bar" elastic#86552
  [ftr/flags] improve help text (elastic#86971)
  skip "Fields Browser rendering. elastic#60209
  skip "Closes and opens alerts" elastic#83773
  [Security Solution] Skip failing Cypress tests (elastic#86967)
  Removes archives (elastic#86537)
  [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 30, 2020
* master: (72 commits)
  [DOCS] Refreshes Data Visualizer screenshot (elastic#87017)
  [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001)
  [securitySolution/cypress] temporarily limit to PRs
  [AppServices/Examples] Add the example for Reporting integration (elastic#82091)
  [Build Chromium] Improve git checkout (elastic#83225)
  Deprecate `services.callCluster` in alerts and actions executors (elastic#86474)
  [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985)
  [Lens] Add more chart editor tests based on the debug state (elastic#86750)
  [Lens] Integrate searchSessionId into Lens app (elastic#86297)
  skip "pagination updates results and page number" elastic#86975
  skip "Custom detection rules" elastic#83772
  [logging/json] use merge from kbn/std (elastic#86330)
  skip network and timeline inspection. elastic#85677, elastic#85678
  skip "adds correctly a filter to the global search bar" elastic#86552
  [ftr/flags] improve help text (elastic#86971)
  skip "Fields Browser rendering. elastic#60209
  skip "Closes and opens alerts" elastic#83773
  [Security Solution] Skip failing Cypress tests (elastic#86967)
  Removes archives (elastic#86537)
  [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly explorer - distribution charts sometimes cut off
4 participants