Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime-UX] Added nav search keywords for uptime and user experience app #90616

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: elastic/uptime#256

Added nav search keywords for uptime and user experience app

User can search for uptime using following keywords

          'Synthetics',
          'pings',
          'checks',
          'availability',
          'response duration',
          'response time',
          'outside in',
          'reachability',
          'reachable',
          'digital',
          'performance',
          'web performance',
          'web perf',

and these deep links are also added


          { id: 'Down monitors', title: 'Down monitors', path: '/?statusFilter=down' },
          { id: 'Certificates', title: 'TLS Certificates', path: '/certificates' },
          { id: 'Settings', title: 'Settings', path: '/settings' },

User can search for UX app using following keywords


          'RUM',
          'Real User Monitoring',
          'DEM',
          'Digital Experience Monitoring',
          'EUM',
          'End User Monitoring',
          'UX',
          'Javascript',
          'APM',
          'Mobile',
          'digital',
          'performance',
          'web performance',
          'web perf',

Screenshots:

image

image

@shahzad31 shahzad31 requested review from a team as code owners February 8, 2021 14:48
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question on the code review.

'Javascript',
'APM',
'Mobile',
'digital',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Digital" seems a little too general to me. Is there some UX-specific context to the term that I am missing?

cc @drewpost

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

'outside in',
'reachability',
'reachable',
'digital',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding digital as the one I had in the UX keywords.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above:

Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic

'End User Monitoring',
'UX',
'Javascript',
'APM',
Copy link
Contributor

@justinkambic justinkambic Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is @elastic/apm-ui ok with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as the first result in the list will always be the APM app, I think we're OK with additionally showing a link to the UX app as well as a secondary option.

Screenshot 2021-02-09 at 09 56 19

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 22.9KB 23.1KB +199.0B
uptime 19.3KB 19.7KB +396.0B
total +595.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any further concerns. LGTM!

@sorenlouv
Copy link
Member

image

Sorry @justinkambic. Not intentional - just fat fingers

@justinkambic
Copy link
Contributor

Not intentional - just fat fingers

@sqren I was clearing GH notifications and came to this comment without any context. Initial reaction was "oh my.. how long has Søren been waiting for this review?" 🤣

@sorenlouv
Copy link
Member

Not very long it turns out :D

@shahzad31 shahzad31 enabled auto-merge (squash) February 9, 2021 20:15
@shahzad31 shahzad31 merged commit 08111e4 into elastic:master Feb 9, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90616 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2021
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 12, 2021
@kibanamachine
Copy link
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","Team:uptime","auto-backport","backport missing","release_note:enhancement","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"08111e40d32583382ae6e6a300f014cef7d18eba\",\"formattedMessage\":\"[Uptime-UX] Added nav search keywords for uptime and user experience app (#90616)\",\"originalMessage\":\"[Uptime-UX] Added nav search keywords for uptime and user experience app (#90616)\",\"pullNumber\":90616,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] [Uptime-UX] Added nav search keywords for uptime and user experience app (#90616)\". kibanamachine:backport/7.x/pr-90616 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 956ms"}
{"level":"info","message":"Adding assignees to #91268: shahzad31"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91268/assignees - 201 in 558ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91268/labels - 200 in 401ms"}
View pull request: https://github.com/elastic/kibana/pull/91268

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 12, 2021
shahzad31 added a commit that referenced this pull request Feb 12, 2021
@shahzad31 shahzad31 deleted the uptime-ux-nav-search branch February 15, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptime and User Experience to be available in Navigational Search
8 participants