Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime-UX] Added nav search keywords for uptime and user experience app #90616

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[Uptime-UX] Added nav search keywords for uptime and user experience app #90616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion x-pack/plugins/apm/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,24 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
order: 8500,
euiIconType: 'logoObservability',
category: DEFAULT_APP_CATEGORIES.observability,

meta: {
keywords: [
'RUM',
'Real User Monitoring',
'DEM',
'Digital Experience Monitoring',
'EUM',
'End User Monitoring',
'UX',
'Javascript',
'APM',
Copy link
Contributor

@justinkambic justinkambic Feb 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is @elastic/apm-ui ok with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as the first result in the list will always be the APM app, I think we're OK with additionally showing a link to the UX app as well as a secondary option.

Screenshot 2021-02-09 at 09 56 19

'Mobile',
'digital',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Digital" seems a little too general to me. Is there some UX-specific context to the term that I am missing?

cc @drewpost

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

'performance',
'web performance',
'web perf',
],
},
async mount(params: AppMountParameters<unknown>) {
// Load application bundle and Get start service
const [{ renderApp }, [coreStart, corePlugins]] = await Promise.all([
Expand Down
22 changes: 22 additions & 0 deletions x-pack/plugins/uptime/public/apps/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,28 @@ export class UptimePlugin
order: 8400,
title: PLUGIN.TITLE,
category: DEFAULT_APP_CATEGORIES.observability,
meta: {
keywords: [
'Synthetics',
'pings',
'checks',
'availability',
'response duration',
'response time',
'outside in',
'reachability',
'reachable',
'digital',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding digital as the one I had in the UX keywords.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above:

Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic

'performance',
'web performance',
'web perf',
],
searchDeepLinks: [
{ id: 'Down monitors', title: 'Down monitors', path: '/?statusFilter=down' },
{ id: 'Certificates', title: 'TLS Certificates', path: '/certificates' },
{ id: 'Settings', title: 'Settings', path: '/settings' },
],
},
mount: async (params: AppMountParameters) => {
const [coreStart, corePlugins] = await core.getStartServices();

Expand Down