Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Restore context documentation #90784

Merged
merged 17 commits into from
Mar 4, 2021
Merged

[Discover] Restore context documentation #90784

merged 17 commits into from
Mar 4, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Feb 9, 2021

Summary

Restores and adapts Discover's Context view documentation.
Bildschirmfoto 2021-02-09 um 15 51 08

Checklist

@kertal kertal self-assigned this Feb 9, 2021
@kertal kertal changed the title [Discover] Restore context doc [Discover] Restore context documentation Feb 9, 2021
kertal
kertal commented Feb 9, 2021
View reviewed changes
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
@kertal kertal requested a review from gchaps February 9, 2021 16:27
gchaps
gchaps reviewed Feb 10, 2021
View reviewed changes
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
@kertal kertal added the Feature:Discover Discover Application label Feb 18, 2021
@kertal kertal added v7.12.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure documentation labels Feb 18, 2021
@kertal kertal requested a review from gchaps February 22, 2021 19:03
@kertal kertal added the v7.13.0 label Feb 22, 2021
gchaps
gchaps reviewed Feb 25, 2021
View reviewed changes
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc Outdated Show resolved Hide resolved
@kertal kertal marked this pull request as ready for review March 2, 2021 15:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Mar 2, 2021
@kertal kertal requested a review from gchaps March 2, 2021 15:51
wylieconlon
wylieconlon approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but unlike regular PRs we should be backporting as far as possible. I think this was removed in 7.10, so we should backport to 7.10

docs/user/discover.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for images, but otherwise LGTM

docs/discover/context.asciidoc Outdated Show resolved Hide resolved
docs/discover/context.asciidoc
and displayed using the same set of columns as the *Discover* view from which
the context was opened. The anchor document is highlighted in blue.
+
[role="screenshot"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the context view to show the anchor doc in the middle, so the reader sees docs both above and below the anchor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've changed it new file is also smaller in size but better in resolution, so it's a win
discover-context

@kertal
Copy link
Member Author

kertal commented Mar 3, 2021

Changes LGTM, but unlike regular PRs we should be backporting as far as possible. I think this was removed in 7.10, so we should backport to 7.10

true dear @gchaps , should we back port it to the versions before 7.12?

@kertal
Copy link
Member Author

kertal commented Mar 4, 2021 •
edited
Loading

Changes LGTM, but unlike regular PRs we should be backporting as far as possible. I think this was removed in 7.10, so we should backport to 7.10

true dear @gchaps , should we back port it to the versions before 7.12?

as discussed offline I'll back port to 7.10

@kertal kertal merged commit 51b416b into elastic:master Mar 4, 2021
kertal added a commit to kertal/kibana that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (elastic#90784)
31af0fb 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
@kertal kertal mentioned this pull request Mar 4, 2021
Merged
kertal added a commit to kertal/kibana that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (elastic#90784)
09ef0f2 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
@kertal kertal mentioned this pull request Mar 4, 2021
Merged
kertal added a commit to kertal/kibana that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (elastic#90784)
1073ab8 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
#	docs/user/discover.asciidoc
@kertal kertal mentioned this pull request Mar 4, 2021
Merged
kertal added a commit that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (#90784) (#93631)
ab60a59 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
kertal added a commit that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (#90784) (#93632)
df5e547 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
kertal added a commit to kertal/kibana that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (elastic#90784)
0b1afde 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
#	docs/user/discover.asciidoc
@kertal kertal mentioned this pull request Mar 4, 2021
Merged
kertal added a commit that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (#90784) (#93634)
9334b20 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
#	docs/user/discover.asciidoc
kertal added a commit that referenced this pull request Mar 4, 2021
@kertal
[Discover] Restore context documentation (#90784) (#93635)
3ca4ded 
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/Discover-ContextView.png
#	docs/user/discover.asciidoc
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
55ff443 
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

@gchaps gchaps gchaps approved these changes

Assignees

@kertal kertal

Labels
documentation Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.3 v7.11.2 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kertal @elasticmachine @wylieconlon @gchaps