Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-docs] Edits core-intro section for the new docs system #93540

Merged

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Mar 4, 2021

#92976 added a new section as a placeholder for core's documentation.
This PR removes the section on legacy Kibana and adds a badge as a reminder to add the remaining user-facing core documentation.

For now, this documentation is a placeholder for other core documentation and has been removed from the new docs system until it finds a home.

Checklist

Delete any items that are not applicable to this PR.

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs v7.13.0 labels Mar 4, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review March 4, 2021 01:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - agree that keeping the legacy section in the new docs system doesn't make sense. Is there a follow-up issue yet to go back and update these?

@TinaHeiligers
Copy link
Contributor Author

Is there a follow-up issue yet to go back and update these?

@lukeelmers Not yet. The nav in the new docs is going to change and I'd rather hold off on adding this new section until such time as the nav outline is there.

For now, we can use this new doc to add in short descriptions and links to other core services as we clean those up.

@TinaHeiligers TinaHeiligers merged commit 70daf80 into elastic:master Mar 4, 2021
@TinaHeiligers TinaHeiligers deleted the core-docs/kibana-server-cleanup branch March 4, 2021 16:19
@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 4, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #93629

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 4, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants