migrate warnings mixin to core #94273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
Mar 10, 2021
| @@ -50,6 +52,14 @@ export class EnvironmentService { | |||
| this.log.warn(`Detected an unhandled Promise rejection.\n${reason}`); | |||
| }); | |||
|
|
|||
| process.on('warning', (warning) => { | |||
| // deprecation warnings do no reflect a current problem for the user and should be filtered out. | |||
| if (warning.name === 'DeprecationWarning') { | |||
There was a problem hiding this comment.
NIT: I know we're simply migrating the legacy logic, but I'm wondering: should we log it when in dev mode so we're all aware of those DeprecationWarnings before it's too late?
There was a problem hiding this comment.
We're logging it in both dev and prod mode. You mean logging it only in dev mode?
There was a problem hiding this comment.
We are currently skipping DeprecationWarning logs. I meant logging DeprecationWarning entries in dev mode.
There was a problem hiding this comment.
@pgayvallet If you're up for it, could you take a look if we're logging config changes from the KP? If so, we can delete that LP log. If not, we'll need to add logs from the KP and then we can delete that LP log.
joshdover
approved these changes
Mar 10, 2021
tylersmalley
approved these changes
Mar 10, 2021
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Mar 10, 2021
pgayvallet
added a commit
that referenced
this pull request
Mar 10, 2021
jloleysens
added a commit
that referenced
this pull request
Mar 11, 2021
…-action * 'master' of github.com:elastic/kibana: (43 commits) [Console] Update copy when showing warnings in response headers (#94270) [TSVB] Type public code. Step 1 (#93231) [ML] Functional tests - stabilize slider value selection (#94313) skip another suite blocking es promotion (#94367) [Security Solution] Eliminates a redundant external link icon (#94194) skip another suite blocking es promotion (#94367) [App Search] Role mappings migration part 1 (#94346) [Security Solution][Detections] Fix flaky indicator enrichment tests (#94241) [Workplace Search] Deduplicate icons (#94359) [ML] Add latest transform to intro text (#94039) skip test failing es promotion (#94367) [Maps] convert elasticsearch_utils to TS (#93984) [Security_Solution][Telemetry] - Update endpoint usage to use agentService (#93829) [Security Solution][Exceptions] Fixes OS adding method for exception enrichment (#94343) [ILM] Add support for frozen phase (#93068) [App Search] Fixed 2 relevance tuning bugs (#94312) remove `try` auth mode (#94287) Removing resolver functional tests (#94331) migrate warning mixin to core (#94273) [App Search] Add routes for Role Mappings (#94221) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/phase/phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_issues_context.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
warningsmixin to core'senvironmentservice, partially addresses Deprecate legacy logging configuration in favour of new logging system #82431configCompleteMixinmixin that is now unused (was exposingserver.config, which is no longer used anywhere in the legacy code)Checklist