[App Search] Role mappings migration part 1 #94346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
Feature:Plugins
release_note:skip
scottybollinger
commented
Mar 10, 2021
...enterprise_search/public/applications/workplace_search/views/role_mappings/role_mappings.tsx
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
...lugins/enterprise_search/public/applications/app_search/components/engines/engines_table.tsx
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
x-pack/plugins/enterprise_search/public/applications/shared/role_mapping/constants.ts
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
...ugins/enterprise_search/public/applications/app_search/utils/role/has_scoped_engines.test.ts
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
x-pack/plugins/enterprise_search/public/applications/app_search/routes.ts
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
x-pack/plugins/enterprise_search/public/applications/app_search/routes.ts
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Mar 10, 2021
x-pack/plugins/enterprise_search/public/applications/app_search/routes.ts
Outdated
Show resolved
Hide resolved
yakhinvadim
approved these changes
Mar 10, 2021
cee-chen
reviewed
Mar 10, 2021
...k/plugins/enterprise_search/public/applications/app_search/components/role_mappings/utils.ts
Show resolved
Hide resolved
|
While I'm here just wanted to say HUGE thanks for making this a super small and atomic PR that I could review between axe-con talks!!! 😍 |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2021
* Fix test suite name https://github.com/elastic/kibana/pull/94038/files#r590545670 * Move types out of AttributeSelector component to shared types * Fix random typo * Add routes and path generator util * Move constants to shared * Fix types in mock * Fix routes * Fix failing tests
kibanamachine
added a commit
that referenced
this pull request
Mar 11, 2021
* Fix test suite name https://github.com/elastic/kibana/pull/94038/files#r590545670 * Move types out of AttributeSelector component to shared types * Fix random typo * Add routes and path generator util * Move constants to shared * Fix types in mock * Fix routes * Fix failing tests Co-authored-by: Scotty Bollinger <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Mar 11, 2021
…-action * 'master' of github.com:elastic/kibana: (43 commits) [Console] Update copy when showing warnings in response headers (#94270) [TSVB] Type public code. Step 1 (#93231) [ML] Functional tests - stabilize slider value selection (#94313) skip another suite blocking es promotion (#94367) [Security Solution] Eliminates a redundant external link icon (#94194) skip another suite blocking es promotion (#94367) [App Search] Role mappings migration part 1 (#94346) [Security Solution][Detections] Fix flaky indicator enrichment tests (#94241) [Workplace Search] Deduplicate icons (#94359) [ML] Add latest transform to intro text (#94039) skip test failing es promotion (#94367) [Maps] convert elasticsearch_utils to TS (#93984) [Security_Solution][Telemetry] - Update endpoint usage to use agentService (#93829) [Security Solution][Exceptions] Fixes OS adding method for exception enrichment (#94343) [ILM] Add support for frozen phase (#93068) [App Search] Fixed 2 relevance tuning bugs (#94312) remove `try` auth mode (#94287) Removing resolver functional tests (#94331) migrate warning mixin to core (#94273) [App Search] Add routes for Role Mappings (#94221) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/phase/phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_issues_context.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first in the migration of the Role Mappings UI to Kibana.
There are 2 unrelated changes I've snuck in here for convenience (b4672cf, 3d38d50)
There are 2 commits that move types (4033d16) and constants (3ed896d) to shared for use in both apps.
Finally, routes and a path generator were added (8920d56).
Checklist