Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Adds Nested CTI row renderer #96275
[Security Solution][Detections] Adds Nested CTI row renderer #96275
Changes from 26 commits
20dd329
6a1a613
9b12c87
e373e78
f42ba60
10a53f8
9d7afd0
adf7067
6fc1d90
c2eb905
b20b71b
39f1880
3477d27
0a6f6fd
f6f887c
72b5b3f
f95f8e3
838e548
73a3d1d
90f6004
d625b2c
d14f795
5fbcf64
d7cce75
5a04c28
d8bf839
2f7433f
d49d692
542052b
9295afc
b115dfe
8f667c7
37d737b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these truly optional? if you have an atomic, shouldn't you always have a field and a type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing
*Ecs
types seemed to be very defensive, where almost everything was optional. If it's one of our detection alerts then it should have all three, but I think these are meant to be general to anything "compliant" with ECS.