Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using incorrect number of parameters #1081

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Oct 8, 2020

With this commit we reenable the pylint check W0221 which checks
whether the correct number of parameters is used in an implemented
or overridden method.

Relates #838

@hub-cap hub-cap added the cleanup Linter changes, reformatting, removal of unused code etc. label Oct 8, 2020
@hub-cap hub-cap added this to the 2.0.2 milestone Oct 8, 2020
@hub-cap hub-cap self-assigned this Oct 8, 2020
@hub-cap hub-cap changed the title Fix pylint W0221 Avoid using incorrect number of parameters Oct 12, 2020
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Oct 19, 2020

@elasticmachine update branch

@hub-cap hub-cap merged commit a71d52c into elastic:master Oct 19, 2020
@hub-cap hub-cap deleted the lint_W0221 branch October 19, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants