Fix linting issues reported by make precommit

[dliappis]

Now that we got infrastructure to enforce coding conventions in #794 we need to start coming up with PRs to fix issues. This issue tracks the effort and should be only closed when make precommit succeeds with no errors reported.

• W0707 (raise-missing-from) - 439
• C4001 - 283
• W0613 - 158
• C0330 - 98 @ebadyano Update .pylintrc to remove exception #1164
• W0621 - 95
• C0415 - 56 @danielmitterdorfer Use top-level imports #1131
• W0612 - 36 @hub-cap Avoid defining and not using variables #1076
• W0221 - 30 @hub-cap Avoid using incorrect number of parameters #1081
• C0301 - 30 @hub-cap Fix lint issue C0301 #855
• E1120 - 27 @hub-cap Avoid passing too few parameters into function calls #1084
• W0212 - 25 @hub-cap Avoid using protected members outside scope #1083
• C0303 - 21 @hub-cap Fix lint issue C0303 #854
• C0302 - 12
• W0404 - 10 @hub-cap Avoid reimporting modules #1080
• W0106 - 9 @hub-cap Avoid assigning an expression to nothing #1082
• C4002 - 9 @hub-cap Avoid invalid triple quotes #1079
• R1722 - 5 @hub-cap Avoid using exit() or quit() #1077
• R0904 - 5 @danielmitterdorfer Avoid too many public methods #1127
• W0311 - 4 @ebadyano Fix lint C0121 and W0311 issues #1021
• W0107 - 4 @hub-cap Fix pylint W0107 #1073
• W0105 - 4 @danielmitterdorfer Check for pointless statements #1039
• W0235 - 3 @hub-cap Fix pylint W0235 #1072
• W0104 - 3 @danielmitterdorfer Check for pointless statements #1039
• R1707 - 3 @danielmitterdorfer Check for trailing comma tuple #1038
• R1704 - 3 @danielmitterdorfer Avoid redefining arguments #1010
• C0121 - 3 @ebadyano Fix lint C0121 and W0311 issues #1021
• E1128 (assignment-from-none) - 2 @danielmitterdorfer Avoid assignment from None #1113
• W1201 - 2 @drawlerr Fix W1201. #869
• W0631 - 2 @drawlerr Fix W0631 #868
• W0143 - 2 @drawlerr Fix W0143 #867
• W0108 - 2 @hub-cap Fix lint issue W0108 #849
• W0102 - 2 @hub-cap Fix lint issue W0102 #848
• C0305 - 2 @hub-cap Fix lint issue C0305 #847
• W1202 - 1 through e0601: @drawlerr Cleanup Pylint singleton issues #845
• W0706 - 1
• W0702 - 1
• W0201 - 1
• W0127 - 1
• R1723 - 1
• R1714 - 1
• R1706 - 1
• R1702 - 1
• R0916 - 1
• R0911 - 1
• E0601 - 1
• C0122 - 1 @hub-cap Fix lint issue C0122 #843

[dliappis]

@drawlerr some top level guidelines to make the corresponding PRs more manageable to review and focus on important topics:

1. This is a frequency chart of warnings/errors/etc. (used make precommit | grep -e '[CRWE][0-9]\{4\}' | awk -F ':' '{print $4}' | sort | uniq -c | sort -n -k 1,1 -r):

 283  C4001
 158  W0613
  98  C0330
  95  W0621
  60  C0326
  56  C0415
  36  W0612
  30  W0221
  30  C0301
  27  E1120
  25  W0212
  21  C0303
  12  C0302
  11  C4002
  10  W0404
   9  W0106
   5  R1722
   5  R0904
   4  W0311
   4  W0107
   4  W0105
   3  W0235
   3  W0104
   3  R1707
   3  R1704
   3  C0121
   2  W1201
   2  W0631
   2  W0143
   2  W0108
   2  W0102
   2  C0305
   1  W1202
   1  W0706
   1  W0702
   1  W0201
   1  W0127
   1  R1723
   1  R1714
   1  R1706
   1  R1702
   1  R0916
   1  R0911
   1  E0601
   1  C0122

2. C4001 i.e. Invalid string quote ', should be " (invalid-string-quote) is very common in unit tests; the intention is not to satisfy pylint and sacrifice readability, so, as an example this would be a valid way to bypass the error in a unit test while retaining readability:

   # pylint: disable=invalid-string-quote
   assert foobar.to_dict('{"k":2, "l":3.4, "m":true, "n":"str"}') == {"k": 2, "l": 3.4, "m": True, "n": "str"}
   

3. One suggestion is to split PRs that address one or more of those categories, e.g. one PR to deal with C4001. If the top two offenders result in huge PRs that are difficult to review, it's ok to additionally split them up e.g. one for core Rally files and another for the unittests.

[michaelbaamonde]

I think we can close this one. make precommit returns no errors on master these days.