Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid assigning an expression to nothing #1082

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Avoid assigning an expression to nothing #1082

merged 3 commits into from
Oct 15, 2020

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Oct 8, 2020 •
edited
Loading

With this commit we reenable the pylint check W0106 which checks
whether an expression not a function call is assigned to nothing.

Relates #838

@hub-cap hub-cap added the cleanup Linter changes, reformatting, removal of unused code etc. label Oct 8, 2020
@hub-cap hub-cap added this to the 2.0.2 milestone Oct 8, 2020
@hub-cap hub-cap requested a review from ebadyano October 8, 2020 18:28
@hub-cap hub-cap self-assigned this Oct 8, 2020
@hub-cap hub-cap mentioned this pull request Oct 8, 2020
Closed
46 tasks
@hub-cap hub-cap changed the title Fix pylint W0106 Avoid assigning an expression to nothing Oct 12, 2020
@ebadyano
Copy link
Contributor

lgtm, thank you

@hub-cap hub-cap merged commit 1bdec4f into elastic:master Oct 15, 2020
@hub-cap hub-cap deleted the lint_W0106 branch October 15, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano Awaiting requested review from ebadyano

Assignees

@hub-cap hub-cap

Labels
cleanup Linter changes, reformatting, removal of unused code etc.
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hub-cap @ebadyano