Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pylintrc to remove exception #1164

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

ebadyano
Copy link
Contributor

@ebadyano ebadyano commented Feb 1, 2021

We currently don't have Wrong hanging indentation errors
Relates to #838

We currently don't have Wrong hanging indentation errors
@ebadyano ebadyano added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. cleanup Linter changes, reformatting, removal of unused code etc. labels Feb 1, 2021
@ebadyano ebadyano added this to the 2.0.4 milestone Feb 1, 2021
@ebadyano ebadyano self-assigned this Feb 1, 2021
@ebadyano
Copy link
Contributor Author

ebadyano commented Feb 1, 2021

build failed, seems like connection issues @elasticmachine test this please

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the cleanup.

Can you please update the PR title / description and the commit title / body when you merge this so it matches the intent (Why are we doing the change?) instead of the action (What are we changing?). See #1131 for an example.

@ebadyano ebadyano merged commit 0dfb58e into elastic:master Feb 2, 2021
@ebadyano
Copy link
Contributor Author

ebadyano commented Feb 2, 2021

@danielmitterdorfer thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants