Fix W0631 #868
Merged
Fix W0631 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
drawlerr
requested review from
dliappis,
hub-cap,
danielmitterdorfer and
ebadyano
|
Dear github, why dont you let me approve this pull request? What did I do to u? Something I have done is not allowing me to LGTM this in a review, so LGTM in a comment. |
danielmitterdorfer
approved these changes
Jan 15, 2020
danielmitterdorfer
added
the
:misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that a refactoring operation resulted in some methods referencing variables from their calling function that were not passed as arguments. Python allows this, but for sanity's sake it's best if function arguments are a bit more explicit.
Relates #838.