Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update incorrect references to "Index pattern" to "Data view" for 8.0.0 #1400

Merged
merged 13 commits into from
Jan 24, 2022

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Jan 13, 2022

Addresses #1373

Previews:

@joepeeples
Copy link
Contributor

@benironside re: your last bullet point above: I think the duplicate text for network map data that you found is related to the older SIEM Guide. The source files for SIEM Guide live in the security-docs repo and contain some of the same content as the newer Security Solution docs. @jmikell821 might know more about the SIEM Guide?

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small fixes.

docs/detections/machine-learning/machine-learning.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
docs/detections/prebuilt-rules/tune-rule-signals.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Just some minor questions and recs. Thanks for this!

docs/getting-started/siem-ui.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/net-map-req.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
@jmikell821
Copy link
Contributor

@benironside re: your last bullet point above: I think the duplicate text for network map data that you found is related to the older SIEM Guide. The source files for SIEM Guide live in the security-docs repo and contain some of the same content as the newer Security Solution docs. @jmikell821 might know more about the SIEM Guide?

Correct. Prior to 7.9 all the docs were in the SIEM Guide, so you may see some duplicates, but those are totally fine to ignore because we aren't really updating anything from <=7.8.

@jmikell821
Copy link
Contributor

Hey @benironside just a few small things:

In the ML topic, let's wrap this in bold text.
2022-01-19_12-22-42

The "Add data" link at the top of the main pages has been replaced with "Add Integrations".
2022-01-19_12-48-42

Should be a simple stitch image editing rather than taking new screen grabs altogether. Not a huge deal but would like the Timeline pages in this PR updated before QA files a bug.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the index pattern/data view terminology. Thank you!

@benironside benironside merged commit d7d628c into main Jan 24, 2022
mergify bot pushed a commit that referenced this pull request Jan 24, 2022
…for 8.0.0 (#1400)

* Update incorrect references to "Index pattern" to "Data view" for 8.0.0

* Add bold format to menu items

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/prebuilt-rules/tune-rule-signals.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/getting-started/siem-ui.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Address Janeen's comments - update images and add bold

* Update docs/getting-started/net-map-req.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Incorporate Steph's feedback

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
(cherry picked from commit d7d628c)
benironside added a commit that referenced this pull request Jan 24, 2022
…for 8.0.0 (#1400) (#1437)

* Update incorrect references to "Index pattern" to "Data view" for 8.0.0

* Add bold format to menu items

* Update docs/detections/machine-learning/machine-learning.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/detections/prebuilt-rules/tune-rule-signals.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/getting-started/siem-ui.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Address Janeen's comments - update images and add bold

* Update docs/getting-started/net-map-req.asciidoc

Co-authored-by: nastasha-solomon <[email protected]>

* Incorporate Steph's feedback

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
(cherry picked from commit d7d628c)

Co-authored-by: benironside <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants