-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Update incorrect references to "Index pattern" to "Data view" for 8.0.0 #1400
Conversation
@benironside re: your last bullet point above: I think the duplicate text for network map data that you found is related to the older SIEM Guide. The source files for SIEM Guide live in the security-docs repo and contain some of the same content as the newer Security Solution docs. @jmikell821 might know more about the SIEM Guide? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small fixes.
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall! Just some minor questions and recs. Thanks for this!
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Correct. Prior to |
Hey @benironside just a few small things: In the ML topic, let's wrap this in bold text. The "Add data" link at the top of the main pages has been replaced with "Add Integrations". Should be a simple stitch image editing rather than taking new screen grabs altogether. Not a huge deal but would like the Timeline pages in this PR updated before QA files a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the index pattern/data view terminology. Thank you!
Co-authored-by: nastasha-solomon <[email protected]>
…for 8.0.0 (#1400) * Update incorrect references to "Index pattern" to "Data view" for 8.0.0 * Add bold format to menu items * Update docs/detections/machine-learning/machine-learning.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/events/timeline-ui-overview.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/detections/prebuilt-rules/tune-rule-signals.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/getting-started/siem-ui.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Update docs/events/timeline-ui-overview.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Address Janeen's comments - update images and add bold * Update docs/getting-started/net-map-req.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Incorporate Steph's feedback Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> (cherry picked from commit d7d628c)
…for 8.0.0 (#1400) (#1437) * Update incorrect references to "Index pattern" to "Data view" for 8.0.0 * Add bold format to menu items * Update docs/detections/machine-learning/machine-learning.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/events/timeline-ui-overview.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/detections/prebuilt-rules/tune-rule-signals.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/getting-started/siem-ui.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Update docs/events/timeline-ui-overview.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Address Janeen's comments - update images and add bold * Update docs/getting-started/net-map-req.asciidoc Co-authored-by: nastasha-solomon <[email protected]> * Incorporate Steph's feedback Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> (cherry picked from commit d7d628c) Co-authored-by: benironside <[email protected]>
Addresses #1373
Previews: