feat!(core): add required Forge version for templates #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Electron Forge templates compatible with v6 must specify the minimum Forge version supported by the template, using the `minimumForgeVersion` attribute on the class implementing `ForgeTemplate`. This is largely to prevent the built-in templates from v5 from being used with v6. Note that actually checking whether the version matches has not been implemented yet.
Codecov Report
@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
+ Coverage 75.03% 75.11% +0.08%
==========================================
Files 91 91
Lines 2339 2347 +8
Branches 437 439 +2
==========================================
+ Hits 1755 1763 +8
Misses 476 476
Partials 108 108
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
BREAKING CHANGE: Electron Forge templates compatible with v6 must specify the required Forge version (i.e., a semver range) supported by the template, using the
requiredForgeVersionattribute on the class implementingForgeTemplate.This is largely to prevent the built-in templates from v5 from being used with v6.
Documented at the Electron Forge website.