Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(core): add required Forge version for templates #2415

Merged
merged 10 commits into from
Aug 1, 2021
Merged

feat!(core): add required Forge version for templates #2415

merged 10 commits into from
Aug 1, 2021

Commits on Jul 29, 2021

  1. feat!(core): require minimum Forge version in templates 

    BREAKING CHANGE: Electron Forge templates compatible with v6 must
specify the minimum Forge version supported by the template, using the
`minimumForgeVersion` attribute on the class implementing `ForgeTemplate`.

This is largely to prevent the built-in templates from v5 from being
used with v6.

Note that actually checking whether the version matches has not been
implemented yet.
    @malept
    malept committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    ca0ab40 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Implement minimum version check

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    79bc20a View commit details
    Browse the repository at this point in the history

  2. s/minimumForgeVersion/requiredForgeVersion/g

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    aa011bc View commit details
    Browse the repository at this point in the history

  3. Fix test

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    fd9adfd View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    4efe1b7 View commit details
    Browse the repository at this point in the history

  5. readRawPackageJson takes a directory

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    784486b View commit details
    Browse the repository at this point in the history

  6. Add tests for thrown errors

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    7dfc6b4 View commit details
    Browse the repository at this point in the history

  7. refactor: move validation code to its own function

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    9d33f5b View commit details
    Browse the repository at this point in the history

  8. async function

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    7b62743 View commit details
    Browse the repository at this point in the history

  9. Fix return type

    @malept
    malept committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    2fa573a View commit details
    Browse the repository at this point in the history