chore: properly check for debug mode for node-gyp loglevel #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 68.69% 69.51% +0.81%
==========================================
Files 11 11
Lines 575 574 -1
Branches 118 118
==========================================
+ Hits 395 399 +4
+ Misses 139 134 -5
Partials 41 41
Continue to review full report at Codecov.
|
mmaietta
changed the title
Updating logic to not rely on DEBUG env var, but instead use the debug module to check if electron-rebuild is enabled electron#594
malept
added a commit
that referenced
this pull request
Aug 24, 2021
malept
added a commit
that referenced
this pull request
Aug 25, 2021
malept
added a commit
that referenced
this pull request
Aug 27, 2021
|
🎉 This issue has been resolved in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating logic to not rely on DEBUG env var, but instead use the debug module to check if electron-rebuild is enabled
Ref: #594